From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Len Brown <lenb@kernel.org>
Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 4/4] ACPI: Make sure the FADT is at least rev 2 before using the reset register
Date: Wed, 23 Mar 2011 10:59:06 +0000 [thread overview]
Message-ID: <20110323105906.GA29657@srcf.ucam.org> (raw)
In-Reply-To: <alpine.LFD.2.02.1103222354150.10549@x980>
On Wed, Mar 23, 2011 at 12:01:50AM -0400, Len Brown wrote:
> if (!(acpi_gbl_FADT.flags & ACPI_FADT_RESET_REGISTER))
> return;
>
> For it not to be redundant, there would have to be FADTs out there
> of revision 1 that set what was then a reserved bit in the flags.
Yes. You trust them not to have set reserved flags to random garbage?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-03-23 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 21:12 [PATCH 1/4] X86: Revamp reboot behaviour to match Windows more closely Matthew Garrett
2011-03-11 21:12 ` [PATCH 2/4] ACPICA: Fix access width for reset vector Matthew Garrett
2011-03-23 3:52 ` Len Brown
2011-03-11 21:12 ` [PATCH 3/4] ACPI: Bug compatibility for Windows on the ACPI reboot vector Matthew Garrett
2011-03-23 3:52 ` Len Brown
2011-03-11 21:12 ` [PATCH 4/4] ACPI: Make sure the FADT is at least rev 2 before using the reset register Matthew Garrett
2011-03-23 4:01 ` Len Brown
2011-03-23 10:59 ` Matthew Garrett [this message]
2011-03-11 22:08 ` [PATCH 1/4] X86: Revamp reboot behaviour to match Windows more closely Rafael J. Wysocki
2011-03-11 22:15 ` Matthew Garrett
2011-03-11 22:18 ` Rafael J. Wysocki
2011-03-23 3:49 ` Len Brown
2011-03-23 4:08 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110323105906.GA29657@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.