From: Ben Dooks <ben-i2c@fluff.org>
To: Tushar Behera <tushar.behera@linaro.org>
Cc: linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
kgene.kim@samsung.com, ben-linux@fluff.org
Subject: Re: [PATCH] I2C:SAMSUNG:Select I2C_S3C2410 if HAVE_S3C2410_I2C
Date: Thu, 24 Mar 2011 10:47:51 +0000 [thread overview]
Message-ID: <20110324104751.GS15795@trinity.fluff.org> (raw)
In-Reply-To: <1300957573-2622-1-git-send-email-tushar.behera@linaro.org>
On Thu, Mar 24, 2011 at 02:36:13PM +0530, Tushar Behera wrote:
> On Samsung Kconfig files, HAVE_S3C2410_I2C is selected if we want
> to enable support for I2C. But the I2C controller is selected only
> if I2C_S3C2410 is defined.
>
> This patch selects I2C_S3C2410 when I2C and HAVE_S3C2410 are selected.
No. Do not do this, just having the device on the board does not mean
you want it forced into the kernel. A user may want to build it as a
module or not build it at-all.
--
Ben Dooks, ben@fluff.org, http://www.fluff.org/ben/
Large Hadron Colada: A large Pina Colada that makes the universe disappear.
next prev parent reply other threads:[~2011-03-24 10:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 9:06 [PATCH] I2C:SAMSUNG:Select I2C_S3C2410 if HAVE_S3C2410_I2C Tushar Behera
2011-03-24 10:47 ` Ben Dooks [this message]
2011-03-25 2:42 ` Tushar Behera
2011-03-25 21:32 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324104751.GS15795@trinity.fluff.org \
--to=ben-i2c@fluff.org \
--cc=ben-linux@fluff.org \
--cc=kgene.kim@samsung.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.