From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [RFCv1 2/3] Bluetooth: remove duplicated code
Date: Thu, 24 Mar 2011 15:57:59 -0300 [thread overview]
Message-ID: <20110324185759.GB2236@joana> (raw)
In-Reply-To: <1300979768-31963-3-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
* Emeltchenko Andrei <Andrei.Emeltchenko.news@gmail.com> [2011-03-24 17:16:07 +0200]:
> From: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
>
> info_timer takes care about removed code
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@nokia.com>
> ---
> net/bluetooth/l2cap_core.c | 12 +++---------
> 1 files changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
> index fd58b8f..4255f00 100644
> --- a/net/bluetooth/l2cap_core.c
> +++ b/net/bluetooth/l2cap_core.c
> @@ -2472,16 +2472,10 @@ static inline int l2cap_information_rsp(struct l2cap_conn *conn, struct l2cap_cm
> return 0;
> }
>
> - del_timer(&conn->info_timer);
> -
> - if (result != L2CAP_IR_SUCCESS) {
> - conn->info_state |= L2CAP_INFO_FEAT_MASK_REQ_DONE;
> - conn->info_ident = 0;
> -
> - l2cap_conn_start(conn);
Are you sure? Does remove this code won't create a delay to call
l2cap_conn_start()?
--
Gustavo F. Padovan
http://profusion.mobi
next prev parent reply other threads:[~2011-03-24 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 15:16 [RFCv1 0/3] Set of patches fixing kernel crash Emeltchenko Andrei
2011-03-24 15:16 ` [RFCv1 1/3] Bluetooth: check info_rsp ident and states Emeltchenko Andrei
2011-03-24 19:11 ` Gustavo F. Padovan
2011-03-24 15:16 ` [RFCv1 2/3] Bluetooth: remove duplicated code Emeltchenko Andrei
2011-03-24 18:57 ` Gustavo F. Padovan [this message]
2011-03-25 9:35 ` Andrei Emeltchenko
2011-03-24 15:16 ` [RFCv1 3/3] Bluetooth: delete hanging L2CAP channel Emeltchenko Andrei
2011-03-24 19:12 ` Gustavo F. Padovan
2011-03-25 8:57 ` Andrei Emeltchenko
2011-03-25 12:35 ` Gustavo F. Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110324185759.GB2236@joana \
--to=padovan@profusion.mobi \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.