From: Thomas Rast <trast@student.ethz.ch>
To: Carl Michael Skog <cmskog@gmail.com>
Cc: <git@vger.kernel.org>
Subject: Re: [PATCH] Test failure when spaces in git root
Date: Thu, 24 Mar 2011 21:46:02 +0100 [thread overview]
Message-ID: <201103242146.02728.trast@student.ethz.ch> (raw)
In-Reply-To: <1300925506-20378-1-git-send-email-cmskog@gmail.com>
Carl Michael Skog wrote:
> Some of the svn related tests would break when the git root path had
> spaces in it.
[...]
> -quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/')"
> +quoted_svnrepo="$(echo $svnrepo | sed 's/ /%20/g')"
If you're already fixing this, shouldn't it be
$(echo "$svnrepo" | ...)
to stop the expansion process from converting arbitrary series of
whitespace into a single space?
However, any other (than space) character that needs %-quoting would
probably also break the test. Maybe some more complicated mangling
would be in order.
--
Thomas Rast
trast@{inf,student}.ethz.ch
prev parent reply other threads:[~2011-03-24 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 0:11 [PATCH] Test failure when spaces in git root Carl Michael Skog
2011-03-24 20:46 ` Thomas Rast [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103242146.02728.trast@student.ethz.ch \
--to=trast@student.ethz.ch \
--cc=cmskog@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.