From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755026Ab1CYUAS (ORCPT ); Fri, 25 Mar 2011 16:00:18 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:37827 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753139Ab1CYUAP (ORCPT ); Fri, 25 Mar 2011 16:00:15 -0400 Date: Fri, 25 Mar 2011 21:00:03 +0100 From: Ingo Molnar To: Pekka Enberg Cc: Thomas Gleixner , Christoph Lameter , torvalds@linux-foundation.org, akpm@linux-foundation.org, tj@kernel.org, npiggin@kernel.dk, rientjes@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [boot crash #2] Re: [GIT PULL] SLAB changes for v2.6.39-rc1 Message-ID: <20110325200003.GC7346@elte.hu> References: <20110324142146.GA11682@elte.hu> <20110324172653.GA28507@elte.hu> <20110324185258.GA28370@elte.hu> <20110324192247.GA5477@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.20 (2009-08-17) X-ELTE-SpamScore: -2.0 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-2.0 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -2.0 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pekka Enberg wrote: > On Thu, Mar 24, 2011 at 9:22 PM, Ingo Molnar wrote: > > > > * Thomas Gleixner wrote: > > > >> On Thu, 24 Mar 2011, Ingo Molnar wrote: > >> > RIP: 0010:[]  [] get_next_timer_interrupt+0x119/0x260 > >> > >> That's a typical timer crash, but you were unable to debug it with > >> debugobjects because commit d3f661d6 broke those. > >> > >> Christoph, debugobjects do not need to run with interupts > >> disabled. And just because they were in that section to keep all the > >> debug stuff together does not make an excuse for not looking at the > >> code and just slopping it into some totally unrelated ifdef along with > >> a completely bogus comment. > >> > >> Signed-off-by: Thomas Gleixner > >> --- > >>  mm/slub.c |    4 ++-- > >>  1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> Index: linux-2.6/mm/slub.c > >> =================================================================== > >> --- linux-2.6.orig/mm/slub.c > >> +++ linux-2.6/mm/slub.c > >> @@ -849,11 +849,11 @@ static inline void slab_free_hook(struct > >>               local_irq_save(flags); > >>               kmemcheck_slab_free(s, x, s->objsize); > >>               debug_check_no_locks_freed(x, s->objsize); > >> -             if (!(s->flags & SLAB_DEBUG_OBJECTS)) > >> -                     debug_check_no_obj_freed(x, s->objsize); > >>               local_irq_restore(flags); > >>       } > >>  #endif > >> +     if (!(s->flags & SLAB_DEBUG_OBJECTS)) > >> +             debug_check_no_obj_freed(x, s->objsize); > > > > Thanks, this did the trick! > > > > Tested-by: Ingo Molnar > > > > With this fix i got the warning below - pinpointing a net/bluetooth/hci_core.c > > timer bug. > > Applied, thanks! Just an update: all SLAB/SLUB problems appear to be fixed with the latest patches, so i'm a happy camper! Thanks Pekka, Ingo From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with ESMTP id F16E88D0040 for ; Fri, 25 Mar 2011 16:00:12 -0400 (EDT) Date: Fri, 25 Mar 2011 21:00:03 +0100 From: Ingo Molnar Subject: Re: [boot crash #2] Re: [GIT PULL] SLAB changes for v2.6.39-rc1 Message-ID: <20110325200003.GC7346@elte.hu> References: <20110324142146.GA11682@elte.hu> <20110324172653.GA28507@elte.hu> <20110324185258.GA28370@elte.hu> <20110324192247.GA5477@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Thomas Gleixner , Christoph Lameter , torvalds@linux-foundation.org, akpm@linux-foundation.org, tj@kernel.org, npiggin@kernel.dk, rientjes@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org * Pekka Enberg wrote: > On Thu, Mar 24, 2011 at 9:22 PM, Ingo Molnar wrote: > > > > * Thomas Gleixner wrote: > > > >> On Thu, 24 Mar 2011, Ingo Molnar wrote: > >> > RIP: 0010:[] [] get_next_timer_interrupt+0x119/0x260 > >> > >> That's a typical timer crash, but you were unable to debug it with > >> debugobjects because commit d3f661d6 broke those. > >> > >> Christoph, debugobjects do not need to run with interupts > >> disabled. And just because they were in that section to keep all the > >> debug stuff together does not make an excuse for not looking at the > >> code and just slopping it into some totally unrelated ifdef along with > >> a completely bogus comment. > >> > >> Signed-off-by: Thomas Gleixner > >> --- > >> mm/slub.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> Index: linux-2.6/mm/slub.c > >> =================================================================== > >> --- linux-2.6.orig/mm/slub.c > >> +++ linux-2.6/mm/slub.c > >> @@ -849,11 +849,11 @@ static inline void slab_free_hook(struct > >> local_irq_save(flags); > >> kmemcheck_slab_free(s, x, s->objsize); > >> debug_check_no_locks_freed(x, s->objsize); > >> - if (!(s->flags & SLAB_DEBUG_OBJECTS)) > >> - debug_check_no_obj_freed(x, s->objsize); > >> local_irq_restore(flags); > >> } > >> #endif > >> + if (!(s->flags & SLAB_DEBUG_OBJECTS)) > >> + debug_check_no_obj_freed(x, s->objsize); > > > > Thanks, this did the trick! > > > > Tested-by: Ingo Molnar > > > > With this fix i got the warning below - pinpointing a net/bluetooth/hci_core.c > > timer bug. > > Applied, thanks! Just an update: all SLAB/SLUB problems appear to be fixed with the latest patches, so i'm a happy camper! Thanks Pekka, Ingo -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org