From: jbrassow@sourceware.org <jbrassow@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/tools lvcreate.c
Date: 25 Mar 2011 21:56:28 -0000 [thread overview]
Message-ID: <20110325215628.9451.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: jbrassow at sourceware.org 2011-03-25 21:56:28
Modified files:
tools : lvcreate.c
Log message:
cosmetic change - swapping one macro for another
When I see 'seg_is_mirrored', I expect the argument to be an lv_segment.
In this case, it is lvcreate_params. Both structures, have a 'segtype'
entry which the macro dereferences. However, it just seems easier to
understand if we do 'segtype_is_mirrored' instead.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/tools/lvcreate.c.diff?cvsroot=lvm2&r1=1.229&r2=1.230
--- LVM2/tools/lvcreate.c 2011/02/18 14:47:31 1.229
+++ LVM2/tools/lvcreate.c 2011/03/25 21:56:28 1.230
@@ -346,7 +346,7 @@
lp->mirrors = 1;
/* Default to 2 mirrored areas if --type mirror */
- if (seg_is_mirrored(lp))
+ if (segtype_is_mirrored(lp->segtype))
lp->mirrors = 2;
if (arg_count(cmd, mirrors_ARG)) {
next reply other threads:[~2011-03-25 21:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 21:56 jbrassow [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-03-02 20:18 LVM2/tools lvcreate.c zkabelac
2012-02-01 1:54 agk
2011-11-10 12:40 zkabelac
2011-11-10 12:39 zkabelac
2011-09-27 12:37 agk
2011-09-07 9:25 zkabelac
2011-09-06 15:35 agk
2010-10-25 12:05 zkabelac
2010-05-11 21:40 jbrassow
2009-07-26 2:32 wysochanski
2009-07-26 2:32 wysochanski
2009-07-26 2:32 wysochanski
2009-07-26 2:31 wysochanski
2009-07-26 2:31 wysochanski
2009-07-26 2:30 wysochanski
2009-06-06 22:06 mbroz
2009-05-27 13:07 agk
2009-04-26 8:12 prajnoha
2008-07-17 15:19 wysochanski
2008-01-16 15:26 agk
2007-10-01 15:01 wysochanski
2007-09-24 13:29 wysochanski
2006-10-16 16:47 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110325215628.9451.qmail@sourceware.org \
--to=jbrassow@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.