From: "J. Bruce Fields" <bfields@fieldses.org>
To: Trond Myklebust <trond@netapp.com>,
"William A.(Andy) Adamson" <andros@citi.umich.edu>
Cc: linux-nfs@vger.kernel.org
Subject: nfs4.1 locking broken
Date: Fri, 25 Mar 2011 22:34:03 -0400 [thread overview]
Message-ID: <20110326023403.GA16277@fieldses.org> (raw)
In-Reply-To: <201103252328.p2PNSVRY013346@pop.test.fieldses.org>
Commit 114f64b5f24abac33a42f4f1856eb3a9766d497e "NFSv4: remove duplicate
clientid in struct nfs_client" breaks locking over 4.1; from a cthon
run:
On Fri, Mar 25, 2011 at 07:28:31PM -0400, J. Bruce Fields wrote:
> Starting LOCKING tests: test directory /mnt/TMP (arg: -f)
>
> Testing native post-LFS locking
>
> Creating parent/child synchronization pipes.
>
> Test #1 - Test regions of an unlocked file.
> Parent: 1.1 - F_TEST [ 0, 1] FAILED!
> Parent: **** Expected success, returned EINVAL...
> Parent: **** Probably implementation error.
>
> ** PARENT pass 1 results: 0/0 pass, 0/0 warn, 1/1 fail (pass/total).
>
> ** CHILD pass 1 results: 0/0 pass, 0/0 warn, 0/0 fail (pass/total).
> lock tests failed
I haven't figured out why.
Presumably the lock code assumed the clientid would be unset in the 4.1
case?
--b.
next parent reply other threads:[~2011-03-26 2:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201103252328.p2PNSVRY013346@pop.test.fieldses.org>
2011-03-26 2:34 ` J. Bruce Fields [this message]
2011-03-29 3:22 ` nfs4.1 locking broken J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110326023403.GA16277@fieldses.org \
--to=bfields@fieldses.org \
--cc=andros@citi.umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=trond@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.