Re: [PATCH] ASoC: ad74111: new codec driver

[Mark Brown <broonie@opensource.wolfsonmicro.com>]

On Sat, Mar 26, 2011 at 04:33:46AM -0400, Mike Frysinger wrote:

>  	select SND_SOC_AD1980 if SND_SOC_AC97_BUS
> -	select SND_SOC_ADS117X
>  	select SND_SOC_AD73311 if I2C
> +	select SND_SOC_AD74111
> +	select SND_SOC_ADS117X

A few of your patches have this sort of additional change in them.
While the cleanup is good it would be better to split it into a separate
patch.  Seeing the unrelated change slows down review and it'll also
create extra merge issues when applying or cherry picking the driver
back to older kernels.

> +static struct platform_driver ad74111_codec_driver = {
> +	.driver = {
> +		.name = "ad74111-codec",

Again, drop the -codec unless this is part of a MFD.

> +/*
> + * definitions for AD74111 registers
> + *

Does this device really have registers?  There's no reference at all to
them in the driver.

> +/* Control register F */
> +#define CTRL_REG_F		(5 << 11)
> +#define REGF_DAC_VOL(x)		((x) & 0x3F)

If the registers should be here they should be namespaced.