From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC] ARM: PXA27x: CPUFREQ: Don't use fastbus mode
Date: Sun, 27 Mar 2011 01:52:45 +0100 [thread overview]
Message-ID: <201103270152.45581.marek.vasut@gmail.com> (raw)
In-Reply-To: <1301169103-23968-1-git-send-email-anarsoul@gmail.com>
On Saturday 26 March 2011 20:51:43 Vasily Khoruzhick wrote:
> PXA27x does not like fastbus for some reason, it can hang in
> random places when it's enabled. So don't use it to make cpufreq
> stable.
This is B/S, you're loosing performance! I'd suggest module parameter or device-
specific callback to toggle use of fastbus on/off.
Cheers
>
> Signed-off-by: Vasily Khoruzhick <anarsoul@gmail.com>
> ---
> arch/arm/mach-pxa/cpufreq-pxa2xx.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/cpufreq-pxa2xx.c
> b/arch/arm/mach-pxa/cpufreq-pxa2xx.c index 6a7aeab..b5727aa 100644
> --- a/arch/arm/mach-pxa/cpufreq-pxa2xx.c
> +++ b/arch/arm/mach-pxa/cpufreq-pxa2xx.c
> @@ -156,13 +156,13 @@ MODULE_PARM_DESC(pxa255_turbo_table, "Selects the
> frequency table (0 = run table ((T) ? CCLKCFG_TURBO : 0))
>
> static pxa_freqs_t pxa27x_freqs[] = {
> - {104000, 104000, PXA27x_CCCR(1, 8, 2), 0, CCLKCFG2(1, 0, 1), 900000,
> 1705000 }, - {156000, 104000, PXA27x_CCCR(1, 8, 3), 0, CCLKCFG2(1, 0, 1),
> 1000000, 1705000 }, + {104000, 104000, PXA27x_CCCR(1, 8, 2), 0,
> CCLKCFG2(0, 0, 1), 900000, 1705000 }, + {156000, 104000, PXA27x_CCCR(1,
> 8, 3), 0, CCLKCFG2(0, 0, 1), 1000000, 1705000 }, {208000, 208000,
> PXA27x_CCCR(0, 16, 2), 1, CCLKCFG2(0, 0, 1), 1180000, 1705000 },
> - {312000, 208000, PXA27x_CCCR(1, 16, 3), 1, CCLKCFG2(1, 0, 1), 1250000,
> 1705000 }, - {416000, 208000, PXA27x_CCCR(1, 16, 4), 1, CCLKCFG2(1, 0, 1),
> 1350000, 1705000 }, - {520000, 208000, PXA27x_CCCR(1, 16, 5), 1,
> CCLKCFG2(1, 0, 1), 1450000, 1705000 }, - {624000, 208000, PXA27x_CCCR(1,
> 16, 6), 1, CCLKCFG2(1, 0, 1), 1550000, 1705000 } + {312000, 208000,
> PXA27x_CCCR(1, 16, 3), 1, CCLKCFG2(0, 0, 1), 1250000, 1705000 },
> + {416000, 208000, PXA27x_CCCR(1, 16, 4), 1, CCLKCFG2(0, 0, 1), 1350000,
> 1705000 }, + {520000, 208000, PXA27x_CCCR(1, 16, 5), 1, CCLKCFG2(0, 0, 1),
> 1450000, 1705000 }, + {624000, 208000, PXA27x_CCCR(1, 16, 6), 1,
> CCLKCFG2(0, 0, 1), 1550000, 1705000 } };
>
> #define NUM_PXA27x_FREQS ARRAY_SIZE(pxa27x_freqs)
next prev parent reply other threads:[~2011-03-27 0:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 19:51 [PATCH RFC] ARM: PXA27x: CPUFREQ: Don't use fastbus mode Vasily Khoruzhick
2011-03-27 0:52 ` Marek Vasut [this message]
2011-03-27 7:28 ` Vasily Khoruzhick
2011-03-27 9:09 ` Igor Grinberg
2011-03-27 9:48 ` Vasily Khoruzhick
2011-03-27 10:09 ` Igor Grinberg
2011-03-27 14:45 ` Vasily Khoruzhick
2011-03-27 14:50 ` Marek Vasut
2011-03-27 14:56 ` Vasily Khoruzhick
2011-03-27 15:34 ` Marek Vasut
2011-03-27 16:56 ` Robert Jarzmik
2011-03-27 17:13 ` Vasily Khoruzhick
2011-03-28 8:22 ` Igor Grinberg
2011-04-11 13:46 ` Pavel Machek
2011-04-11 20:11 ` Vasily Khoruzhick
2011-04-12 5:22 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103270152.45581.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.