From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH 01/13] KVM: x86 emulator: add framework for instruction
Date: Sun, 27 Mar 2011 14:56:56 +0200
Message-ID: <20110327125656.GE7766@redhat.com>
References: <1301045356-25257-1-git-send-email-joerg.roedel@amd.com>
 <1301045356-25257-2-git-send-email-joerg.roedel@amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>,
	kvm@vger.kernel.org
To: Joerg Roedel <joerg.roedel@amd.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx1.redhat.com ([209.132.183.28]:46498 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751076Ab1C0M47 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sun, 27 Mar 2011 08:56:59 -0400
Content-Disposition: inline
In-Reply-To: <1301045356-25257-2-git-send-email-joerg.roedel@amd.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Fri, Mar 25, 2011 at 10:29:04AM +0100, Joerg Roedel wrote:
> @@ -259,6 +267,18 @@ struct x86_emulate_ctxt {
>  #define X86EMUL_MODE_PROT32   4	/* 32-bit protected mode. */
>  #define X86EMUL_MODE_PROT64   8	/* 64-bit (long) mode.    */
>  
> +enum x86_intercept_stage {
> +	x86_icpt_pre_except,
> +	x86_icpt_post_except,
> +	x86_icpt_post_memaccess,
> +};
> +
> +enum x86_intercept {
> +	x86_intercept_none,
> +
> +	nr_x86_intercepts
> +};
> +
Can we name enums in upper case please?

--
			Gleb.