From: "wanlong.gao" <wanlong.gao@gmail.com>
To: "Alexey Dobriyan" <adobriyan@gmail.com>
Cc: "greg" <greg@kroah.com>, "harryxiyou" <harryxiyou@gmail.com>,
"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH] Fixed the format: lines over 80 characters .
Date: Sun, 27 Mar 2011 22:31:46 +0800 [thread overview]
Message-ID: <201103272231385006098@gmail.com> (raw)
In-Reply-To: 20110327125359.GA5816@p183.telecom.by
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 1024 bytes --]
But if you read the code in the 80 columns screen , isn't it less readable with the code over 80 characters ?
-------------------------------------------------------------
·¢¼þÈË£ºAlexey Dobriyan
·¢ËÍÈÕÆÚ£º2011-03-27 21:54:05
ÊÕ¼þÈË£ºwanlong.gao
³ËÍ£ºgreg; harryxiyou; linux-kernel
Ö÷Ì⣺Re: [PATCH] Fixed the format: lines over 80 characters .
On Sun, Mar 27, 2011 at 11:07:24AM +0800, wanlong.gao@gmail.com wrote:
> Lines over 80 characters
> static DEFINE_PCI_DEVICE_TABLE(cmodio_pci_ids) = {
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030, PCI_VENDOR_ID_JANZ, 0x0101 },
> - { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050, PCI_VENDOR_ID_JANZ, 0x0100 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9030,
> + PCI_VENDOR_ID_JANZ, 0x0101 },
> + { PCI_VENDOR_ID_PLX, PCI_DEVICE_ID_PLX_9050,
> + PCI_VENDOR_ID_JANZ, 0x0100 },
NAK, this is less readable.
ÿôèº{.nÇ+·®+%Ëÿ±éݶ\x17¥wÿº{.nÇ+·¥{±þG«éÿ{ayº\x1dÊÚë,j\a¢f£¢·hïêÿêçz_è®\x03(éÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?¨èÚ&£ø§~á¶iOæ¬z·vØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?I¥
next prev parent reply other threads:[~2011-03-27 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-27 3:07 [PATCH] Fixed the format: lines over 80 characters wanlong.gao
2011-03-27 12:53 ` Alexey Dobriyan
2011-03-27 14:12 ` wanlong.gao
2011-03-27 14:31 ` wanlong.gao [this message]
2011-03-28 17:30 ` Steven Rostedt
2011-03-28 4:59 ` Harry Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103272231385006098@gmail.com \
--to=wanlong.gao@gmail.com \
--cc=adobriyan@gmail.com \
--cc=greg@kroah.com \
--cc=harryxiyou@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.