From: David Miller <davem@davemloft.net>
To: mkl@pengutronix.de
Cc: Netdev@vger.kernel.org, kernel@pengutronix.de
Subject: Re: BUG: ping without route segfaults in dst_release
Date: Mon, 28 Mar 2011 16:51:49 -0700 (PDT) [thread overview]
Message-ID: <20110328.165149.193711805.davem@davemloft.net> (raw)
In-Reply-To: <4D911758.3010608@pengutronix.de>
From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: Tue, 29 Mar 2011 01:18:48 +0200
> root@ptx:~ ping 130.75.1.32
> PING 130.75.1.32 (130.75[ 10.160000] Unable to handle kernel paging request at virtual address ffffffdb
Well, that was easy enough :-)
--------------------
ipv4: Don't ip_rt_put() an error pointer in RAW sockets.
Reported-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
---
net/ipv4/raw.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
index e837ffd..2d3c72e 100644
--- a/net/ipv4/raw.c
+++ b/net/ipv4/raw.c
@@ -569,6 +569,7 @@ static int raw_sendmsg(struct kiocb *iocb, struct sock *sk, struct msghdr *msg,
rt = ip_route_output_flow(sock_net(sk), &fl4, sk);
if (IS_ERR(rt)) {
err = PTR_ERR(rt);
+ rt = NULL;
goto done;
}
}
--
1.7.4.1
next prev parent reply other threads:[~2011-03-28 23:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 23:18 BUG: ping without route segfaults in dst_release Marc Kleine-Budde
2011-03-28 23:51 ` David Miller [this message]
2011-03-29 0:00 ` Marc Kleine-Budde
2011-03-29 0:18 ` Marc Kleine-Budde
2011-03-29 0:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328.165149.193711805.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Netdev@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.