From mboxrd@z Thu Jan  1 00:00:00 1970
From: Joerg Roedel <joro@8bytes.org>
Subject: Re: [PATCH 01/13] KVM: x86 emulator: add framework for instruction
Date: Mon, 28 Mar 2011 12:19:34 +0200
Message-ID: <20110328101933.GE28219@8bytes.org>
References: <1301045356-25257-1-git-send-email-joerg.roedel@amd.com> <1301045356-25257-2-git-send-email-joerg.roedel@amd.com> <20110327125656.GE7766@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Joerg Roedel <joerg.roedel@amd.com>, Avi Kivity <avi@redhat.com>,
	Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from 8bytes.org ([88.198.83.132]:60578 "EHLO 8bytes.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751051Ab1C1KTh (ORCPT <rfc822;kvm@vger.kernel.org>);
	Mon, 28 Mar 2011 06:19:37 -0400
Content-Disposition: inline
In-Reply-To: <20110327125656.GE7766@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Sun, Mar 27, 2011 at 02:56:56PM +0200, Gleb Natapov wrote:
> On Fri, Mar 25, 2011 at 10:29:04AM +0100, Joerg Roedel wrote:
> > @@ -259,6 +267,18 @@ struct x86_emulate_ctxt {
> >  #define X86EMUL_MODE_PROT32   4	/* 32-bit protected mode. */
> >  #define X86EMUL_MODE_PROT64   8	/* 64-bit (long) mode.    */
> >  
> > +enum x86_intercept_stage {
> > +	x86_icpt_pre_except,
> > +	x86_icpt_post_except,
> > +	x86_icpt_post_memaccess,
> > +};
> > +
> > +enum x86_intercept {
> > +	x86_intercept_none,
> > +
> > +	nr_x86_intercepts
> > +};
> > +
> Can we name enums in upper case please?

Just did a quick grep and it seems that both, upper and lower case is
used in enums throughout the kernel. It makes certainly sense to have it
in upper case to make a visual distinction between constants and
variables, but for the x86_intercept enum this means clobbering the
opcode-tables in the emulator with upper-case strings making them less
readable imo.
But I change x86_intercept_stage to upper-case in the next version.

	Joerg