From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Jon Mason <jdmason@kudzu.us>
Cc: netdev@vger.kernel.org, Ben Hutchings <bhutchings@solarflare.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
Jesse Gross <jesse@nicira.com>,
Amit Kumar Salecha <amit.salecha@qlogic.com>,
Shreyas Bhatewara <sbhatewara@vmware.com>,
Jesper Dangaard Brouer <hawk@comx.dk>
Subject: Re: [PATCH] net: fix ethtool->set_flags not intended -EINVAL return value
Date: Mon, 28 Mar 2011 16:48:37 +0200 [thread overview]
Message-ID: <20110328144837.GB4037@redhat.com> (raw)
In-Reply-To: <20110328142155.GA26423@kudzu.us>
On Mon, Mar 28, 2011 at 09:21:57AM -0500, Jon Mason wrote:
> > - if (data & ~ETH_FLAG_RXHASH)
> > - return -EOPNOTSUPP;
> > + if (ethtool_invalid_flags(dev, data, ETH_FLAG_RXHASH))
> > + return -EINVAL;
>
> The return code value is being changed, which is not relevant to this
> patch. Perhaps a secondary patch should be created to make all driver
> set_flags calls return EOPNOTSUPP for unsupported flag setting.
Linux network developers agree some time ago that EINVAL should be used
in this case.
Stanislaw
prev parent reply other threads:[~2011-03-28 14:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-23 9:54 [PATCH] net: fix ethtool->set_flags not intended -EINVAL return value Stanislaw Gruszka
2011-03-28 14:21 ` Jon Mason
2011-03-28 14:48 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110328144837.GB4037@redhat.com \
--to=sgruszka@redhat.com \
--cc=amit.salecha@qlogic.com \
--cc=bhutchings@solarflare.com \
--cc=eric.dumazet@gmail.com \
--cc=hawk@comx.dk \
--cc=jdmason@kudzu.us \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=sbhatewara@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.