All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vinicius Costa Gomes <vinicius.gomes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 0/6] Move Attrib client (including: should we disconnect or not?)
Date: Mon, 28 Mar 2011 17:33:47 -0300	[thread overview]
Message-ID: <20110328203346.GA2664@piper> (raw)
In-Reply-To: <1301097673-5262-1-git-send-email-vinicius.gomes@openbossa.org>

Hi Johan,

On 21:01 Fri 25 Mar, Vinicius Costa Gomes wrote:
> Hi,
> 
> The move itself is pretty simple, but when implementing it, I took a decision
> and I would like to hear your opinion about it.

There were problems with some useless includes. I will send another version
soon. But the question below remains.

> 
> With this patch series, the behaviour is that we never disconnect from
> a LE device unless we are told so, i.e. org.bluez.Device.Disconnect(),
> is that what is expected from us?
> 
> 
> Cheers,
> --
> 
> Vinicius Costa Gomes (6):
>   Move Attrib client to the core
>   Register Attrib interface when loading device from storage
>   Register Attrib interface after Primary Service discovery
>   Remove _init and _exit methods from Attrib client
>   Add support for re-using the attrib channel
>   Fix disconnecting when primary service discovery is done
> 
>  Makefile.am      |    4 ++--
>  attrib/client.c  |   49 ++++++++++++++++++-------------------------------
>  attrib/client.h  |    6 +++---
>  attrib/manager.c |   47 -----------------------------------------------
>  src/adapter.c    |    5 +++++
>  src/device.c     |   20 +++++++++++++-------
>  6 files changed, 41 insertions(+), 90 deletions(-)
> 
> --
> 1.7.4.1
> 

Cheers,
-- 
Vinicius

  parent reply	other threads:[~2011-03-28 20:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-26  0:01 [PATCH 0/6] Move Attrib client (including: should we disconnect or not?) Vinicius Costa Gomes
2011-03-26  0:01 ` [PATCH 1/6] Move Attrib client to the core Vinicius Costa Gomes
2011-03-26  0:01 ` [PATCH 2/6] Register Attrib interface when loading device from storage Vinicius Costa Gomes
2011-03-26  0:01 ` [PATCH 3/6] Register Attrib interface after Primary Service discovery Vinicius Costa Gomes
2011-03-26  0:01 ` [PATCH 4/6] Remove _init and _exit methods from Attrib client Vinicius Costa Gomes
2011-03-26  0:01 ` [PATCH 5/6] Add support for re-using the attrib channel Vinicius Costa Gomes
2011-03-26  0:01 ` [PATCH 6/6] Fix disconnecting when primary service discovery is done Vinicius Costa Gomes
2011-03-28 20:33 ` Vinicius Costa Gomes [this message]
2011-03-28 20:40   ` [PATCH 0/6] Move Attrib client (including: should we disconnect or not?) Claudio Takahasi
2011-03-28 20:48     ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110328203346.GA2664@piper \
    --to=vinicius.gomes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.