From: David Miller <davem@davemloft.net>
To: bhutchings@solarflare.com
Cc: shemminger@vyatta.com, netdev@vger.kernel.org
Subject: Re: ethtool physical identify vs netlink locking?
Date: Tue, 29 Mar 2011 17:13:28 -0700 (PDT) [thread overview]
Message-ID: <20110329.171328.28814158.davem@davemloft.net> (raw)
In-Reply-To: <1301443676.10056.57.camel@localhost>
From: Ben Hutchings <bhutchings@solarflare.com>
Date: Wed, 30 Mar 2011 01:07:56 +0100
> In the sfc driver, physical ID used to be delegated to the PHY
> operations. Then I realised that it was pointless to use a PHY's blink
> mode where it was available and a periodic timer on the host where it
> wasn't, when the latter would work for all of them. So I would propose:
>
> 4. Define a ethtool operation 'set_id_state' with an argument that sets
> identification on/off/inactive/active (the last optional, for any driver
> that really wants to do this differently). When this is defined, the
> ethtool core runs the loop and acquires the lock each time it calls this
> operation.
>
> This requires changes to every driver, though not all at once. As an
> additional benefit, it should result in consistent behaviour for the
> count = 0 case.
This seems like a good way to solve the problem.
next prev parent reply other threads:[~2011-03-30 0:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 20:52 ethtool physical identify vs netlink locking? Stephen Hemminger
2011-03-30 0:07 ` Ben Hutchings
2011-03-30 0:13 ` David Miller [this message]
2011-03-30 0:23 ` Stephen Hemminger
2011-03-30 1:35 ` Michał Mirosław
2011-03-30 6:29 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329.171328.28814158.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.