From: Johan Herland <johan@herland.net>
To: Michael J Gruber <git@drmicha.warpmail.net>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] git-notes.txt: clarify -C vs. copy and -F
Date: Tue, 29 Mar 2011 11:36:42 +0200 [thread overview]
Message-ID: <201103291136.42830.johan@herland.net> (raw)
In-Reply-To: <09668994f10284cfa5243789a627dce8c2325bc6.1301388217.git.git@drmicha.warpmail.net>
On Tuesday 29 March 2011, Michael J Gruber wrote:
> The current description of '-C' together with the analogy to 'git
> commit -C' can lead to the wrong conclusion that '-C' copies notes
> between objects. Make this clearer by rewording and pointing to
> 'copy'.
>
> The example for attaching binary notes with 'git hash-object'
> followed by 'git notes add -C' immediately raises the question: "Why
> not use 'git notes add -F'?". Answer it (the latter is not
> binary-safe).
>
> Signed-off-by: Michael J Gruber <git@drmicha.warpmail.net>
Acked-by: Johan Herland <johan@herland.net>
...Johan
--
Johan Herland, <johan@herland.net>
www.herland.net
next prev parent reply other threads:[~2011-03-29 9:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 8:45 [PATCH] git-notes.txt: clarify -C vs. copy and -F Michael J Gruber
2011-03-29 9:36 ` Johan Herland [this message]
2011-03-29 18:22 ` Junio C Hamano
2011-03-29 18:25 ` Junio C Hamano
2011-03-29 18:36 ` Michael J Gruber
2011-03-29 19:04 ` Junio C Hamano
2011-03-29 19:57 ` Junio C Hamano
2011-08-25 10:26 ` Michael J Gruber
2011-08-25 18:50 ` Johan Herland
2011-03-30 0:02 ` [RFC/PATCH] Make "git notes add" more user-friendly when there are existing notes Johan Herland
2011-03-30 6:54 ` Michael J Gruber
2011-03-30 9:59 ` Johan Herland
2011-04-04 11:35 ` Lasse Makholm
2011-04-04 12:54 ` Michael J Gruber
2011-03-30 19:32 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201103291136.42830.johan@herland.net \
--to=johan@herland.net \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.