From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Robert Gerlach <khnz@gmx.de>
Cc: "Ryan H. Lewis" <me@ryanlewis.net>, platform-driver-x86@vger.kernel.org
Subject: Re: [RESEND PATCH] Fujitsu tablet pc extras driver
Date: Tue, 29 Mar 2011 13:13:01 +0100 [thread overview]
Message-ID: <20110329121301.GA11850@srcf.ucam.org> (raw)
In-Reply-To: <20110329121103.GA5922@knothebonkz.local>
On Tue, Mar 29, 2011 at 02:11:03PM +0200, Robert Gerlach wrote:
> On Tue, Mar 29, 2011 at 11:33:22AM +0100, Matthew Garrett wrote:
> > You're binding to an ACPI device here - does it have a _CRS method? If
> > so, you should retrieve the resource information from acpipnp rather
> > than hardcoding it. That'll involve reworking it as an acpi driver
> > rather than a platform one, but that should be easy enough.
>
> Yes, it have a _CRS, but I removed the code because it is always the same
> IRQ and IO range. I'll reimplement with the first device it make it
> necessary.
Chances are that it'll always be that, but it's better to use the
firmware data rather than hardcoding.
Thanks!
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2011-03-29 12:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 10:03 [RESEND PATCH] Fujitsu tablet pc extras driver Robert Gerlach
2011-03-29 10:33 ` Matthew Garrett
2011-03-29 12:11 ` Robert Gerlach
2011-03-29 12:13 ` Matthew Garrett [this message]
2011-03-31 5:50 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329121301.GA11850@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=khnz@gmx.de \
--cc=me@ryanlewis.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.