All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Travis <travis@sgi.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	Jack Steiner <steiner@sgi.com>,
	Lee Schermerhorn <lee.schermerhorn@hp.com>,
	Andy Shevchenko <andy.shevchenko@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] bitmap, irq: Add smp_affinity_list interface to /proc/irq
Date: Tue, 29 Mar 2011 16:56:12 -0700	[thread overview]
Message-ID: <20110329165612.bd6ad7e4.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D926F6C.8010705@sgi.com>

On Tue, 29 Mar 2011 16:46:52 -0700
Mike Travis <travis@sgi.com> wrote:

> +	/* create /proc/irq/<irq>/smp_affinity_list */
> +	proc_create_data("smp_affinity_list", 0600, desc->dir,
> +			 &irq_affinity_list_proc_fops, (void *)(long)irq);

Always document your interfaces, please.  `grep -r smp_affinity
Documentation' shows where.

And one we've seen a description of the proposed new interface, we can
review the patch!

  reply	other threads:[~2011-03-29 23:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-29 23:46 [PATCH] bitmap, irq: Add smp_affinity_list interface to /proc/irq Mike Travis
2011-03-29 23:56 ` Andrew Morton [this message]
2011-03-30  0:43   ` Andrew Morton
2011-03-30  0:51     ` Mike Travis
2011-03-30  0:56       ` Andrew Morton
2011-03-30  0:58         ` Mike Travis
2011-03-30  1:04         ` Mike Travis
2011-03-30  1:13           ` Andrew Morton
2011-03-31  7:37             ` KOSAKI Motohiro
2011-03-31 18:15               ` Mike Frysinger
2011-03-30  1:12 ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110329165612.bd6ad7e4.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=lee.schermerhorn@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.