From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Michael Witten <mfwitten@gmail.com>
Cc: Raghavendra D Prabhu <rprabhu@wnohang.net>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use the environment variable PYTHON if defined
Date: Tue, 29 Mar 2011 17:40:25 -0300 [thread overview]
Message-ID: <20110329204024.GA20824@ghostprotocols.net> (raw)
In-Reply-To: <AANLkTi=3Wq3Xt-QFR-FLRQ1kBjpWjaBZNFpOiE_T15WH@mail.gmail.com>
Em Tue, Mar 29, 2011 at 02:15:30PM -0500, Michael Witten escreveu:
> On Tue, Mar 29, 2011 at 13:15, Raghavendra D Prabhu <rprabhu@wnohang.net> wrote:
> > the patch submitted by Michael seems to be taking care of far
> > more cases than mine, so that is much better.
>
> One major issue with my current patch is that I opted to stop the
> build with an error message even when using the default python command
> names; is this undesirable? Is it better to fail silently as before
> (via the somewhat cryptic Python.h message), or is it better to force
> the user to specify that no python support should be built?
I think that the best course of action is to emit a warning and go, i.e.
we don't have to make it harder for people that don't want $FOO support
to make that clear.
Just not having python-dev{el} installed should be enough to disable the
feature. For people that want the feature the warning is enough to tell
them to install the missing package.
- Arnaldo
next prev parent reply other threads:[~2011-03-29 20:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-26 22:44 [PATCH] Use the environment variable PYTHON if defined Raghavendra D Prabhu
2011-03-28 14:47 ` Arnaldo Carvalho de Melo
2011-03-28 22:36 ` Michael Witten
2011-03-29 18:15 ` Raghavendra D Prabhu
2011-03-29 19:15 ` Michael Witten
2011-03-29 20:40 ` Arnaldo Carvalho de Melo [this message]
2011-03-29 21:02 ` Michael Witten
2011-03-29 21:14 ` Arnaldo Carvalho de Melo
2011-03-31 19:15 ` Raghavendra D Prabhu
2011-03-31 20:29 ` Michael Witten
2011-04-02 20:46 ` Raghavendra D Prabhu
2011-04-02 22:40 ` Michael Witten
2011-03-31 15:37 ` Michael Witten
2011-04-08 21:17 ` Raghavendra D Prabhu
2011-04-09 1:24 ` Michael Witten
2011-04-02 21:46 ` [PATCH 2/2] perf tools: Makefile: PYTHON{,_CONFIG} to bandage Python 3 incompatibility Michael Witten
2011-04-09 1:12 ` [PATCH 1/2] perf tools: Makefile: Clean up `python/perf.so' rule Michael Witten
2011-04-09 18:42 ` [PATCH] Use the environment variable PYTHON if defined Raghavendra D Prabhu
2011-04-09 20:34 ` Michael Witten
2011-04-12 20:52 ` [PULL] Improve Python 3 handling Michael Witten
2011-04-21 9:22 ` [tip:perf/core] perf tools: Makefile: PYTHON{,_CONFIG} to bandage Python 3 incompatibility tip-bot for Michael Witten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110329204024.GA20824@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mfwitten@gmail.com \
--cc=rprabhu@wnohang.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.