All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: simon@mungewell.org
Cc: gregkh@suse.de, linux-usb@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	david-b@pacbell.net
Subject: Re: [PATCH] pl25a1_support
Date: Wed, 30 Mar 2011 02:40:04 -0700 (PDT)	[thread overview]
Message-ID: <20110330.024004.45902973.davem@davemloft.net> (raw)
In-Reply-To: <1301456667-1648-1-git-send-email-simon@mungewell.org>

From: Simon Wood <simon@mungewell.org>
Date: Tue, 29 Mar 2011 21:44:27 -0600

> @@ -89,13 +97,17 @@ static int pl_reset(struct usbnet *dev)
>  	/* some units seem to need this reset, others reject it utterly.
>  	 * FIXME be more like "naplink" or windows drivers.
>  	 */
> -	(void) pl_set_QuickLink_features(dev,
> +	int     status;
> +
> +        status = pl_set_QuickLink_features(dev,
>  		PL_S_EN|PL_RESET_OUT|PL_RESET_IN|PL_PEER_E);

Poor indentation here in the status assignment, there should be
only a single TAB character before "status =".

Also, declare the local variable at the beginning of the function,
before the function, not after it.  And get rid of that tab between
"int" and "status, like this:

	int status;

	/* some units seem to need this reset, others reject it utterly.
	 * FIXME be more like "naplink" or windows drivers.
	 */

  reply	other threads:[~2011-03-30  9:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30  3:44 [PATCH] pl25a1_support Simon Wood
2011-03-30  3:44 ` Simon Wood
2011-03-30  9:40 ` David Miller [this message]
2011-03-30 11:31 ` Sergei Shtylyov
2011-04-06  4:16 ` [PatchV2 : PL25A1 Support - 1/3] whitespace Simon Wood
2011-04-06 20:17   ` David Miller
2011-04-06  4:16 ` [PatchV2 : PL25A1 Support - 2/3] add_pl25a1 Simon Wood
2011-04-06  4:16   ` Simon Wood
2011-04-06  4:16 ` [PatchV2 : PL25A1 Support - 3/3] reset_debug Simon Wood
2011-04-07  7:40 ` [PatchV3 1/3] usb: plusb: Whitespace Simon Wood
2011-04-07  7:40   ` [PatchV3 2/3] usb: plusb: Add support for PL-25A1 Simon Wood
2011-04-11  1:47     ` David Miller
2011-04-07  7:40   ` [PatchV3 3/3] usb: plusb: Add debug to reset function Simon Wood
2011-04-11  1:47     ` David Miller
2011-04-11  1:47   ` [PatchV3 1/3] usb: plusb: Whitespace David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110330.024004.45902973.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=david-b@pacbell.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=simon@mungewell.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.