* [PATCH] sound/soc/pxa/zylonite.c: set .codec_dai_name in initializer
@ 2011-03-18 11:47 ` Antonio Ospite
0 siblings, 0 replies; 8+ messages in thread
From: Antonio Ospite @ 2011-03-18 11:47 UTC (permalink / raw)
To: alsa-devel
Cc: Antonio Ospite, Eric Miao, Russell King, Liam Girdwood,
Mark Brown, Jaroslav Kysela, Takashi Iwai, Jarkko Nikula,
Timur Tabi, Sascha Hauer, linux-arm-kernel, linux-kernel
Fix the initialization of .codec_dai_name in zylonite_dai initializer,
do not mix it with the initialization of .codec_name which is set
already a few lines above.
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
Hi,
I didn't test that because I don't have the hardware, I just noticed it by
reading the code from 2.6.38 and thought this may be the right fix.
Is there any mechanism to spot out when the same field in a struct initializer
is set more than once?
Regards,
Antonio Ospite
http://ao2.it
sound/soc/pxa/zylonite.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/pxa/zylonite.c b/sound/soc/pxa/zylonite.c
index 25bba10..5e96f7e 100644
--- a/sound/soc/pxa/zylonite.c
+++ b/sound/soc/pxa/zylonite.c
@@ -167,7 +167,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
.codec_name = "wm9713-codec",
.platform_name = "pxa-pcm-audio",
.cpu_dai_name = "pxa2xx-ac97",
- .codec_name = "wm9713-hifi",
+ .codec_dai_name = "wm9713-hifi",
.init = zylonite_wm9713_init,
},
{
@@ -176,7 +176,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
.codec_name = "wm9713-codec",
.platform_name = "pxa-pcm-audio",
.cpu_dai_name = "pxa2xx-ac97-aux",
- .codec_name = "wm9713-aux",
+ .codec_dai_name = "wm9713-aux",
},
{
.name = "WM9713 Voice",
@@ -184,7 +184,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
.codec_name = "wm9713-codec",
.platform_name = "pxa-pcm-audio",
.cpu_dai_name = "pxa-ssp-dai.2",
- .codec_name = "wm9713-voice",
+ .codec_dai_name = "wm9713-voice",
.ops = &zylonite_voice_ops,
},
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] sound/soc/pxa/zylonite.c: set .codec_dai_name in initializer
@ 2011-03-18 11:47 ` Antonio Ospite
0 siblings, 0 replies; 8+ messages in thread
From: Antonio Ospite @ 2011-03-18 11:47 UTC (permalink / raw)
To: linux-arm-kernel
Fix the initialization of .codec_dai_name in zylonite_dai initializer,
do not mix it with the initialization of .codec_name which is set
already a few lines above.
Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
---
Hi,
I didn't test that because I don't have the hardware, I just noticed it by
reading the code from 2.6.38 and thought this may be the right fix.
Is there any mechanism to spot out when the same field in a struct initializer
is set more than once?
Regards,
Antonio Ospite
http://ao2.it
sound/soc/pxa/zylonite.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/pxa/zylonite.c b/sound/soc/pxa/zylonite.c
index 25bba10..5e96f7e 100644
--- a/sound/soc/pxa/zylonite.c
+++ b/sound/soc/pxa/zylonite.c
@@ -167,7 +167,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
.codec_name = "wm9713-codec",
.platform_name = "pxa-pcm-audio",
.cpu_dai_name = "pxa2xx-ac97",
- .codec_name = "wm9713-hifi",
+ .codec_dai_name = "wm9713-hifi",
.init = zylonite_wm9713_init,
},
{
@@ -176,7 +176,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
.codec_name = "wm9713-codec",
.platform_name = "pxa-pcm-audio",
.cpu_dai_name = "pxa2xx-ac97-aux",
- .codec_name = "wm9713-aux",
+ .codec_dai_name = "wm9713-aux",
},
{
.name = "WM9713 Voice",
@@ -184,7 +184,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
.codec_name = "wm9713-codec",
.platform_name = "pxa-pcm-audio",
.cpu_dai_name = "pxa-ssp-dai.2",
- .codec_name = "wm9713-voice",
+ .codec_dai_name = "wm9713-voice",
.ops = &zylonite_voice_ops,
},
};
--
1.7.4.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] sound/soc/pxa/zylonite.c: set .codec_dai_name in initializer
2011-03-18 11:47 ` Antonio Ospite
(?)
@ 2011-03-26 15:01 ` Eric Miao
-1 siblings, 0 replies; 8+ messages in thread
From: Eric Miao @ 2011-03-26 15:01 UTC (permalink / raw)
To: Antonio Ospite
Cc: alsa-devel, Russell King, Takashi Iwai, Sascha Hauer, Mark Brown,
linux-kernel, Timur Tabi, linux-arm-kernel, Liam Girdwood
On Fri, Mar 18, 2011 at 7:47 PM, Antonio Ospite
<ospite@studenti.unina.it> wrote:
> Fix the initialization of .codec_dai_name in zylonite_dai initializer,
> do not mix it with the initialization of .codec_name which is set
> already a few lines above.
>
> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
> ---
>
> Hi,
>
> I didn't test that because I don't have the hardware, I just noticed it by
> reading the code from 2.6.38 and thought this may be the right fix.
>
> Is there any mechanism to spot out when the same field in a struct initializer
> is set more than once?
>
> Regards,
> Antonio Ospite
> http://ao2.it
>
> sound/soc/pxa/zylonite.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/pxa/zylonite.c b/sound/soc/pxa/zylonite.c
> index 25bba10..5e96f7e 100644
> --- a/sound/soc/pxa/zylonite.c
> +++ b/sound/soc/pxa/zylonite.c
> @@ -167,7 +167,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
> .codec_name = "wm9713-codec",
> .platform_name = "pxa-pcm-audio",
> .cpu_dai_name = "pxa2xx-ac97",
> - .codec_name = "wm9713-hifi",
> + .codec_dai_name = "wm9713-hifi",
> .init = zylonite_wm9713_init,
> },
> {
> @@ -176,7 +176,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
> .codec_name = "wm9713-codec",
> .platform_name = "pxa-pcm-audio",
> .cpu_dai_name = "pxa2xx-ac97-aux",
> - .codec_name = "wm9713-aux",
> + .codec_dai_name = "wm9713-aux",
> },
> {
> .name = "WM9713 Voice",
> @@ -184,7 +184,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
> .codec_name = "wm9713-codec",
> .platform_name = "pxa-pcm-audio",
> .cpu_dai_name = "pxa-ssp-dai.2",
> - .codec_name = "wm9713-voice",
> + .codec_dai_name = "wm9713-voice",
> .ops = &zylonite_voice_ops,
> },
> };
> --
> 1.7.4.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] sound/soc/pxa/zylonite.c: set .codec_dai_name in initializer
@ 2011-03-26 15:01 ` Eric Miao
0 siblings, 0 replies; 8+ messages in thread
From: Eric Miao @ 2011-03-26 15:01 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Mar 18, 2011 at 7:47 PM, Antonio Ospite
<ospite@studenti.unina.it> wrote:
> Fix the initialization of .codec_dai_name in zylonite_dai initializer,
> do not mix it with the initialization of .codec_name which is set
> already a few lines above.
>
> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
> ---
>
> Hi,
>
> I didn't test that because I don't have the hardware, I just noticed it by
> reading the code from 2.6.38 and thought this may be the right fix.
>
> Is there any mechanism to spot out when the same field in a struct initializer
> is set more than once?
>
> Regards,
> ? Antonio Ospite
> ? http://ao2.it
>
> ?sound/soc/pxa/zylonite.c | ? ?6 +++---
> ?1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/pxa/zylonite.c b/sound/soc/pxa/zylonite.c
> index 25bba10..5e96f7e 100644
> --- a/sound/soc/pxa/zylonite.c
> +++ b/sound/soc/pxa/zylonite.c
> @@ -167,7 +167,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
> ? ? ? ?.codec_name = "wm9713-codec",
> ? ? ? ?.platform_name = "pxa-pcm-audio",
> ? ? ? ?.cpu_dai_name = "pxa2xx-ac97",
> - ? ? ? .codec_name = "wm9713-hifi",
> + ? ? ? .codec_dai_name = "wm9713-hifi",
> ? ? ? ?.init = zylonite_wm9713_init,
> ?},
> ?{
> @@ -176,7 +176,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
> ? ? ? ?.codec_name = "wm9713-codec",
> ? ? ? ?.platform_name = "pxa-pcm-audio",
> ? ? ? ?.cpu_dai_name = "pxa2xx-ac97-aux",
> - ? ? ? .codec_name = "wm9713-aux",
> + ? ? ? .codec_dai_name = "wm9713-aux",
> ?},
> ?{
> ? ? ? ?.name = "WM9713 Voice",
> @@ -184,7 +184,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
> ? ? ? ?.codec_name = "wm9713-codec",
> ? ? ? ?.platform_name = "pxa-pcm-audio",
> ? ? ? ?.cpu_dai_name = "pxa-ssp-dai.2",
> - ? ? ? .codec_name = "wm9713-voice",
> + ? ? ? .codec_dai_name = "wm9713-voice",
> ? ? ? ?.ops = &zylonite_voice_ops,
> ?},
> ?};
> --
> 1.7.4.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] sound/soc/pxa/zylonite.c: set .codec_dai_name in initializer
@ 2011-03-26 15:01 ` Eric Miao
0 siblings, 0 replies; 8+ messages in thread
From: Eric Miao @ 2011-03-26 15:01 UTC (permalink / raw)
To: Antonio Ospite
Cc: alsa-devel, Takashi Iwai, Sascha Hauer, Mark Brown, linux-kernel,
Jaroslav Kysela, Jarkko Nikula, Russell King, Timur Tabi,
linux-arm-kernel, Liam Girdwood
On Fri, Mar 18, 2011 at 7:47 PM, Antonio Ospite
<ospite@studenti.unina.it> wrote:
> Fix the initialization of .codec_dai_name in zylonite_dai initializer,
> do not mix it with the initialization of .codec_name which is set
> already a few lines above.
>
> Signed-off-by: Antonio Ospite <ospite@studenti.unina.it>
Acked-by: Eric Miao <eric.y.miao@gmail.com>
> ---
>
> Hi,
>
> I didn't test that because I don't have the hardware, I just noticed it by
> reading the code from 2.6.38 and thought this may be the right fix.
>
> Is there any mechanism to spot out when the same field in a struct initializer
> is set more than once?
>
> Regards,
> Antonio Ospite
> http://ao2.it
>
> sound/soc/pxa/zylonite.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/pxa/zylonite.c b/sound/soc/pxa/zylonite.c
> index 25bba10..5e96f7e 100644
> --- a/sound/soc/pxa/zylonite.c
> +++ b/sound/soc/pxa/zylonite.c
> @@ -167,7 +167,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
> .codec_name = "wm9713-codec",
> .platform_name = "pxa-pcm-audio",
> .cpu_dai_name = "pxa2xx-ac97",
> - .codec_name = "wm9713-hifi",
> + .codec_dai_name = "wm9713-hifi",
> .init = zylonite_wm9713_init,
> },
> {
> @@ -176,7 +176,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
> .codec_name = "wm9713-codec",
> .platform_name = "pxa-pcm-audio",
> .cpu_dai_name = "pxa2xx-ac97-aux",
> - .codec_name = "wm9713-aux",
> + .codec_dai_name = "wm9713-aux",
> },
> {
> .name = "WM9713 Voice",
> @@ -184,7 +184,7 @@ static struct snd_soc_dai_link zylonite_dai[] = {
> .codec_name = "wm9713-codec",
> .platform_name = "pxa-pcm-audio",
> .cpu_dai_name = "pxa-ssp-dai.2",
> - .codec_name = "wm9713-voice",
> + .codec_dai_name = "wm9713-voice",
> .ops = &zylonite_voice_ops,
> },
> };
> --
> 1.7.4.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] sound/soc/pxa/zylonite.c: set .codec_dai_name in initializer
2011-03-18 11:47 ` Antonio Ospite
(?)
@ 2011-03-30 0:31 ` Mark Brown
-1 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2011-03-30 0:31 UTC (permalink / raw)
To: Antonio Ospite
Cc: alsa-devel, Russell King, Takashi Iwai, Sascha Hauer,
linux-kernel, Eric Miao, Timur Tabi, linux-arm-kernel,
Liam Girdwood
On Fri, Mar 18, 2011 at 12:47:33PM +0100, Antonio Ospite wrote:
> Fix the initialization of .codec_dai_name in zylonite_dai initializer,
> do not mix it with the initialization of .codec_name which is set
> already a few lines above.
Applied, thanks.
As discussed via IRC please fix your mail setup so it can deliver to
hosts without MX records. Please also try to cut down the CC lists a
bit - don't blindly trust get_maintainers.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] sound/soc/pxa/zylonite.c: set .codec_dai_name in initializer
@ 2011-03-30 0:31 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2011-03-30 0:31 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Mar 18, 2011 at 12:47:33PM +0100, Antonio Ospite wrote:
> Fix the initialization of .codec_dai_name in zylonite_dai initializer,
> do not mix it with the initialization of .codec_name which is set
> already a few lines above.
Applied, thanks.
As discussed via IRC please fix your mail setup so it can deliver to
hosts without MX records. Please also try to cut down the CC lists a
bit - don't blindly trust get_maintainers.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] sound/soc/pxa/zylonite.c: set .codec_dai_name in initializer
@ 2011-03-30 0:31 ` Mark Brown
0 siblings, 0 replies; 8+ messages in thread
From: Mark Brown @ 2011-03-30 0:31 UTC (permalink / raw)
To: Antonio Ospite
Cc: alsa-devel, Eric Miao, Russell King, Liam Girdwood,
Jaroslav Kysela, Takashi Iwai, Jarkko Nikula, Timur Tabi,
Sascha Hauer, linux-arm-kernel, linux-kernel
On Fri, Mar 18, 2011 at 12:47:33PM +0100, Antonio Ospite wrote:
> Fix the initialization of .codec_dai_name in zylonite_dai initializer,
> do not mix it with the initialization of .codec_name which is set
> already a few lines above.
Applied, thanks.
As discussed via IRC please fix your mail setup so it can deliver to
hosts without MX records. Please also try to cut down the CC lists a
bit - don't blindly trust get_maintainers.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-03-30 0:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-18 11:47 [PATCH] sound/soc/pxa/zylonite.c: set .codec_dai_name in initializer Antonio Ospite
2011-03-18 11:47 ` Antonio Ospite
2011-03-26 15:01 ` Eric Miao
2011-03-26 15:01 ` Eric Miao
2011-03-26 15:01 ` Eric Miao
2011-03-30 0:31 ` Mark Brown
2011-03-30 0:31 ` Mark Brown
2011-03-30 0:31 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.