From: Christoph Hellwig <hch@lst.de>
To: Jens Axboe <jaxboe@fusionio.com>
Cc: linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, neilb@suse.de
Subject: blk_flush_plug in the MD code, was Re: [xfs-masters] linux-next: manual merge of the xfs tree with Linus' tree
Date: Wed, 30 Mar 2011 13:57:38 +0200 [thread overview]
Message-ID: <20110330115738.GA16484@lst.de> (raw)
In-Reply-To: <4D93177B.50505@fusionio.com>
On Wed, Mar 30, 2011 at 01:43:55PM +0200, Jens Axboe wrote:
> On 2011-03-29 22:08, Christoph Hellwig wrote:
> > FYI, the blk_flush_plug call in ufs_truncate also seem to be almost
> > certainly incorrect as it's followed by a yield.
> >
> > That only leaves the RAID code as remaining modular users of it, and
> > I suspect it really is something that shouldn't need to be exported.
>
> Agree, once things have settled down we can reap the remaining and keep
> it internal.
In fact I think the blk_flush_plug calls in the raid1/raid10 code can
simply be removed without a replacement. They are in wait_even_loops
which schedule before/after the call so we do get the implicit context
switch plugs there. Even more they are generally called from the
make_request handler, which for MD is in the loop around
__generic_make_request and thus can't actually unplug in a sensible
way.
next prev parent reply other threads:[~2011-03-30 11:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-28 1:21 linux-next: manual merge of the xfs tree with Linus' tree Stephen Rothwell
2011-03-28 10:47 ` [xfs-masters] " Christoph Hellwig
2011-03-28 10:53 ` Christoph Hellwig
2011-03-28 10:58 ` Jens Axboe
2011-03-28 10:58 ` Jens Axboe
2011-03-28 11:00 ` Christoph Hellwig
2011-03-29 2:57 ` Alex Elder
2011-03-29 2:57 ` Alex Elder
2011-03-29 20:08 ` Christoph Hellwig
2011-03-30 11:43 ` Jens Axboe
2011-03-30 11:57 ` Christoph Hellwig [this message]
2011-03-28 13:37 ` Stephen Rothwell
2011-03-28 13:44 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330115738.GA16484@lst.de \
--to=hch@lst.de \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.