From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-mm@kvack.org, Paul Mundt <lethal@linux-sh.org>
Subject: Re: [PATCH] mm: fix setup_zone_pageset section mismatch
Date: Wed, 30 Mar 2011 15:53:16 -0700 [thread overview]
Message-ID: <20110330155316.e11d760c.akpm@linux-foundation.org> (raw)
In-Reply-To: <4D93B302.9090103@oracle.com>
On Wed, 30 Mar 2011 15:47:30 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:
> ...
>
> >
> > I already merged Paul Mundt's patch whcih marks build_all_zonelists()
> > as __ref. That seems a better solution?
>
> Merged where? mmotm?
mm.
--- a/mm/page_alloc.c~mm-page_allocc-silence-build_all_zonelists-section-mismatch
+++ a/mm/page_alloc.c
@@ -3170,7 +3170,7 @@ static __init_refok int __build_all_zone
* Called with zonelists_mutex held always
* unless system_state == SYSTEM_BOOTING.
*/
-void build_all_zonelists(void *data)
+void __ref build_all_zonelists(void *data)
{
set_zonelist_order();
_
>
> ...
>
> > If we'd handled the section via
> >
> > #ifdef CONFIG_MEMORY_HOTPLUG
> > #define __meminit
> > #else
> > #define __meminit __init
> > #endif
> >
> > of similar then that would fix things. iirc we used to do it that
> > way...
>
> Yes, that older way made more sense to me.
I guess it was too simple.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-03-30 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-24 20:24 [PATCH] mm: fix setup_zone_pageset section mismatch Randy Dunlap
2011-03-30 22:05 ` Andrew Morton
2011-03-30 22:47 ` Randy Dunlap
2011-03-30 22:53 ` Andrew Morton [this message]
2011-03-31 0:28 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330155316.e11d760c.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=lethal@linux-sh.org \
--cc=linux-mm@kvack.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.