From: Christoph Hellwig <hch@lst.de>
To: Benny Halevy <bhalevy@panasas.com>
Cc: Christoph Hellwig <hch@lst.de>,
Jim@lst.de, "Rees <rees"@citi.umich.edu,
linux-nfs@vger.kernel.org
Subject: Re: [RFC] spnfs-block: restore i_op->fallocate
Date: Wed, 30 Mar 2011 17:58:11 +0200 [thread overview]
Message-ID: <20110330155811.GA21931@lst.de> (raw)
In-Reply-To: <1301500460-16467-1-git-send-email-bhalevy@panasas.com>
On Wed, Mar 30, 2011 at 05:54:20PM +0200, Benny Halevy wrote:
> spnfsd-blocks needs the old inode_operations API for fallocate
> as it does not have a struct_file in hand.
>
> As all file systems (but xfs) currently use the struct file argument
> to get to the inode move their implementation back into a inode operation.
> Introduce generic_file_fallocate that can be used as the file_operations
> method that just does that and calls i_op->fallocate.
>
> Refactor the xfs implementation and introduce _xfs_vn_fallocate
> that takes an addition attr_flags, which value depends on the struct file
> argument to xfs_file_fallocate.
NAK. Not only isn't spnfsd-block not upstream, but I probably never will be
given what a piece of junk it is.
Second making fallocate a file operation was done on purpose, and all the
other filesystem need the same fix that xfs has - making the allocation
stable if done on an O_SYNC file descriptor.
next parent reply other threads:[~2011-03-30 15:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1301500460-16467-1-git-send-email-bhalevy@panasas.com>
2011-03-30 15:58 ` Christoph Hellwig [this message]
2011-03-30 17:11 ` [RFC] spnfs-block: restore i_op->fallocate Benny Halevy
2011-03-30 17:33 ` Christoph Hellwig
2011-03-31 6:53 ` Benny Halevy
2011-03-31 13:53 ` Christoph Hellwig
2011-04-01 8:30 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110330155811.GA21931@lst.de \
--to=hch@lst.de \
--cc="Rees <rees"@citi.umich.edu \
--cc=Jim@lst.de \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.