All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Lina Lu" <lulina_nuaa@foxmail.com>
To: "Vivek Goyal" <vgoyal@redhat.com>
Cc: "linux kernel mailing list" <linux-kernel@vger.kernel.org>
Subject: cfq-iosched.c:Use cfqq->nr_sectors in charge the vdisktime
Date: Wed, 30 Mar 2011 23:23:30 +0800	[thread overview]
Message-ID: <201103302323256090890@foxmail.com> (raw)

Hi Vivek,
      I find the weight policy can be more accuracy with cfqq->nr_sectors instead
of cfqq->slice_dispatch. 
      Today, I try to modify cfq_group_served(), and use "charge = cfqq->nr_sectors; "
instead of "charge = cfqq->slice_dispatch; " . The test result seens more accuracy.
Why you choose slice_dispatch here? Is the nr_sectors will lower the total performance?
      And in iops mod, if I try to apply weight policy on two IO processes with different 
avgrq-sz, the test results will not exact match the weight value.

Thanks
Lina


             reply	other threads:[~2011-03-30 15:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-30 15:23 Lina Lu [this message]
2011-03-30 15:54 ` cfq-iosched.c:Use cfqq->nr_sectors in charge the vdisktime Vivek Goyal
2011-03-31 15:46 ` Lina Lu
2011-03-31 19:46   ` Vivek Goyal
2011-04-01 14:59   ` Lina Lu
2011-04-01 15:22     ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201103302323256090890@foxmail.com \
    --to=lulina_nuaa@foxmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.