From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: fix extent format buffer allocation size
Date: Thu, 31 Mar 2011 16:51:14 +1100 [thread overview]
Message-ID: <20110331055114.GC30279@dastard> (raw)
In-Reply-To: <20110330093333.GA32582@infradead.org>
On Wed, Mar 30, 2011 at 05:33:34AM -0400, Christoph Hellwig wrote:
> > + xfs_bmbt_rec_t *ext_buffer;
> > +
> > + ext_buffer = kmem_alloc(XFS_IFORK_SIZE(ip, whichfork),
>
> If the fork size be the minimum of XFS_IFORK_SIZE and the if_bytes
> value?
I thought about that, but I don't think it makes any difference. If
there are no delalloc extents, then XFS_IFORK_SIZE and ifp->if_bytes
are identical when the fork is in extent format. If there are
delalloc extents, then XFS_IFORK_SIZE() is the one we want. Hence I
don't think we need to even consider the value of ifp->if_bytes at
all here....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-03-31 5:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 2:52 [PATCH] xfs: fix extent format buffer allocation size Dave Chinner
2011-03-30 9:33 ` Christoph Hellwig
2011-03-31 5:51 ` Dave Chinner [this message]
2011-03-31 6:29 ` Christoph Hellwig
2011-04-04 20:09 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331055114.GC30279@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.