All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Mickler <florian@mickler.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	kurup_avinash@yahoo.com, maciej.rutecki@gmail.com, rjw@sisk.pl,
	sedat.dilek@gmail.com, zersaa@gmail.com, stable@kernel.org
Subject: Re: [PATCH][POKE] Skip looking for ioapic overrides when ioapics are not present
Date: Thu, 31 Mar 2011 12:59:41 +0200	[thread overview]
Message-ID: <20110331125941.661a0af9@schatten.dmk.lab> (raw)
In-Reply-To: <20110331084342.GA30105@elte.hu>

On Thu, 31 Mar 2011 10:43:42 +0200
Ingo Molnar <mingo@elte.hu> wrote:

> 
> * Florian Mickler <florian@mickler.org> wrote:
> 
> > From: Eric W. Biederman <ebiederm@xmission.com>
> > 
> > [I submit this as the corresponding bug report is still not closed, the patch 
> > not merged, distributions applying this patch, it is tested to work and I found
> > nowhere any resoning as to why this should be out of tree. I just guessed on
> > the stable tag and number. -Florian] 
> 
> The patch does not build when CONFIG_ACPI is disabled:
> 
>  arch/x86/kernel/apic/io_apic.c: In function ‘acpi_get_override_irq’:
>  arch/x86/kernel/apic/io_apic.c:3792:6: error: ‘acpi_irq_model’ undeclared (first use in this function)
>  arch/x86/kernel/apic/io_apic.c:3792:24: error: ‘ACPI_IRQ_MODEL_IOAPIC’ undeclared (first use in this function)
> 
> When you or Eric resubmits the fixed patch please use the improved changelog 
> below.
> 
> Thanks,
> 
> 	Ingo

Thank you. Will do if it turns out this is still necessary. 
Paul Bolle mentioned in another messgage that there is a commit in
2.6.38 to the same effect:

commit 678301ecadec24ff77ab310eebf8a32ccddb1850 
("x86, ioapic: Don't warn about non-existing IOAPICs if we have none")

Regards,
Flo

  reply	other threads:[~2011-03-31 11:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31  8:01 [PATCH][POKE] Skip looking for ioapic overrides when ioapics are not present Florian Mickler
2011-03-31  8:43 ` Ingo Molnar
2011-03-31 10:59   ` Florian Mickler [this message]
2011-04-02 15:11     ` [stable] " Andi Kleen
2011-04-02 18:35       ` Ingo Molnar
2011-04-01  1:23   ` [PATCH v2] x86, ioapic: " Florian Mickler
2011-04-01  6:20     ` Ingo Molnar
2011-04-01  6:43       ` Eric W. Biederman
2011-04-01  6:47       ` Len Brown
2011-04-01  7:50         ` Ingo Molnar
2011-04-01 15:44           ` [PATCH] x86, ioapic: move acpi_get_override_irq to acpi.c Florian Mickler
2011-04-01 16:26             ` Florian Mickler
2011-04-03 14:34               ` Florian Mickler
2011-04-04 15:00                 ` Ingo Molnar
2011-04-12  7:39             ` Ingo Molnar
2011-04-12 19:53               ` Florian Mickler
2011-04-12 20:01                 ` [PATCH 1/2 v2] x86, ioapic: Skip looking for ioapic overrides when ioapics are not present Florian Mickler
2011-04-12 20:01                   ` [PATCH 2/2 v2] x86, ioapic: move acpi_get_override_irq to acpi.c Florian Mickler
2011-04-15 10:19                     ` Ingo Molnar
2011-05-17 14:38                       ` Florian Mickler
2011-03-31  8:48 ` [PATCH][POKE] Skip looking for ioapic overrides when ioapics are not present Paul Bolle
2011-03-31 10:53   ` Florian Mickler
2011-03-31 11:01     ` Sedat Dilek
2011-03-31 12:05       ` Eric W. Biederman
2011-03-31 12:43         ` Ingo Molnar
2011-04-02  0:48           ` Eric W. Biederman
2011-04-02 18:43             ` Ingo Molnar
2011-04-02 22:21               ` Eric W. Biederman
2011-03-31 13:16       ` Florian Mickler
2011-03-31 13:25         ` Sedat Dilek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110331125941.661a0af9@schatten.dmk.lab \
    --to=florian@mickler.org \
    --cc=akpm@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=kurup_avinash@yahoo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maciej.rutecki@gmail.com \
    --cc=mingo@elte.hu \
    --cc=rjw@sisk.pl \
    --cc=sedat.dilek@gmail.com \
    --cc=stable@kernel.org \
    --cc=zersaa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.