All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Cliff Wickman <cpw@sgi.com>
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, tglx@linutronix.de,
	rja@sgi.com
Subject: Re: [PATCH v3] x86: UV kdump reboot fix
Date: Thu, 31 Mar 2011 17:57:54 +0200	[thread overview]
Message-ID: <20110331155754.GC9827@elte.hu> (raw)
In-Reply-To: <E1Q5Iuo-00013b-UK@eag09.americas.sgi.com>


* Cliff Wickman <cpw@sgi.com> wrote:

> Diffed against 2.6.38-rc8 (current tip tree)

It does not apply here:

patching file arch/x86/kernel/apic/x2apic_uv_x.c
Hunk #1 FAILED at 23.
Hunk #2 succeeded at 35 (offset 1 line).
Hunk #3 succeeded at 812 (offset 1 line).
1 out of 3 hunks FAILED -- rejects in file arch/x86/kernel/apic/x2apic_uv_x.c

But yeah, the patch looks good now.

One minor nit, please watch out for the proper capitalization of sentences:

> +
> +	/*
> +	 * for a kdump kernel the reset must be BOOT_ACPI, not BOOT_EFI, as
> +	 * EFI is not enabled in the kdump kernel.
> +	 */
> +	if (is_kdump_kernel())
> +		reboot_type = BOOT_ACPI;

Thanks,

	Ingo

  reply	other threads:[~2011-03-31 15:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-31 14:32 [PATCH v3] x86: UV kdump reboot fix Cliff Wickman
2011-03-31 15:57 ` Ingo Molnar [this message]
2011-03-31 20:06 ` [tip:x86/urgent] x86, UV: Fix kdump reboot tip-bot for Cliff Wickman
2011-04-02 20:47 ` [PATCH v3] x86: UV kdump reboot fix Valdis.Kletnieks
2011-04-03  0:01   ` Russ Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110331155754.GC9827@elte.hu \
    --to=mingo@elte.hu \
    --cc=cpw@sgi.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rja@sgi.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.