From: Jonathan Nieder <jrnieder@gmail.com>
To: Brandon Casey <brandon.casey.ctr@nrlssc.navy.mil>
Cc: "Øyvind A. Holm" <sunny@sunbase.org>, git@vger.kernel.org
Subject: Re: 195b7ca6 breaks t9010 at current master
Date: Thu, 31 Mar 2011 16:14:43 -0500 [thread overview]
Message-ID: <20110331211443.GC19932@elie> (raw)
In-Reply-To: <YHiIPkNCiU3RcX-PxtGuaAPfpIMSLtDzcuGX-pUHbb_4SC5aAQu_WQ@cipher.nrlssc.navy.mil>
Hi,
Brandon Casey wrote:
> I was just about to send a patch for this, when I noticed it has
> already been worked around in master by the above.
>
> I'll still share my one-liner for informational purposes which uses perl
> and in my opinion is a little simpler:
>
> --- a/t/t9010-svn-fe.sh
> +++ b/t/t9010-svn-fe.sh
> @@ -465,7 +465,7 @@ test_expect_success 'NUL in log message, file content, and property name' '
> git diff-tree --root --stdin |
> sed "s/$_x40/OBJID/g"
> } >actual &&
> - git cat-file commit HEAD | nul_to_q | sed -ne "/^\$/,\$ p" >actual.message &&
> + git cat-file commit HEAD | nul_to_q | perl -ne "print if (/^$/..eof())" >actual.message &&
> git cat-file blob HEAD^:greeting | nul_to_q >actual.hello1 &&
> git cat-file blob HEAD:greeting | nul_to_q >actual.hello2 &&
> test_cmp expect actual &&
Thanks. I'll definitely use that idiom the next time this sed gotcha
comes up.
Also if you're interested, I'd be happy to take a patch on top to
make it so as a cleanup (probably splitting the line at the same time,
since it's getting pretty long).
prev parent reply other threads:[~2011-03-31 21:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 2:08 195b7ca6 breaks t9010 at current master Øyvind A. Holm
2011-03-29 4:24 ` Jonathan Nieder
2011-03-29 7:06 ` Brian Gernhardt
2011-03-29 7:24 ` [PULL svn-fe] " Jonathan Nieder
2011-03-29 13:37 ` Øyvind A. Holm
2011-03-31 16:11 ` Brandon Casey
2011-03-31 21:14 ` Jonathan Nieder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110331211443.GC19932@elie \
--to=jrnieder@gmail.com \
--cc=brandon.casey.ctr@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=sunny@sunbase.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.