All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Stefan Haller <lists@haller-berlin.de>
Cc: git@vger.kernel.org, Mark Lodato <lodatom@gmail.com>
Subject: Re: Completion for branches or tags broken with zsh
Date: Sat, 2 Apr 2011 17:50:45 -0500	[thread overview]
Message-ID: <20110402225045.GA22781@elie> (raw)
In-Reply-To: <1jxqbmc.vc0luayavmrkM%lists@haller-berlin.de>

Hi Stefan,

Stefan Haller wrote:

> In the current master (and 1.7.4), tab completion for refs doesn't work
> in zsh.  When typing "git log orig<TAB>", nothing appears.

Sorry for the long silence.  Indeed, it seems that I broke this in
da48616f1d (bash: get --pretty=m<tab> completion to work with bash v4,
2010-12-02).  No fix yet.

Here's the puzzle: _git calls _get_comp_words_by_ref to fill the local
array "${words[@]}".  It doesn't succeed.  Within _get_comp_words_by_ref,
${words[@]} gets filled correctly, but within _git, it keeps the value it
previously had.

Alas, that's as far as I can get without learning something about zsh. :)
I can't reproduce it when defining functions like this directly, so
there might be something subtle going on.

Hints?

Thanks for noticing.
Jonathan

      reply	other threads:[~2011-04-02 22:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-06 21:38 Completion for branches or tags broken with zsh Stefan Haller
2011-04-02 22:50 ` Jonathan Nieder [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110402225045.GA22781@elie \
    --to=jrnieder@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=lists@haller-berlin.de \
    --cc=lodatom@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.