From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: pawel@osciak.com
Cc: mchehab@redhat.com, linux-media@vger.kernel.org, zyprowski@samsung.com
Subject: Re: vb2_plane 'mapped' signed bit field
Date: Sun, 3 Apr 2011 01:24:28 +0100 [thread overview]
Message-ID: <20110403002428.GD3062@gallifrey> (raw)
In-Reply-To: <20110403001856.GC3062@gallifrey>
(Originally sent to Pawel's Samsung address that bounced)
* Dr. David Alan Gilbert (linux@treblig.org) wrote:
> Hi Pawel,
> 'sparse' spotted that vb2_plane's mapped field is a signed
> bitfield:
>
> include/media/videobuf2-core.h:78:41 1 bit signed int
>
> struct vb2_plane {
> void *mem_priv;
> int mapped:1;
> };
>
> that probably should be an unsigned int (I can see code that assigns
> 1 to it that just won't fit).
>
> (Introduced by e23ccc0ad9258634e6d52cedf473b35dc34416c7 , spotted in
> 2.6.39-rc1 )
>
> Dave
> --
> -----Open up your eyes, open up your mind, open up your code -------
> / Dr. David Alan Gilbert | Running GNU/Linux | Happy \
> \ gro.gilbert @ treblig.org | | In Hex /
> \ _________________________|_____ http://www.treblig.org |_______/
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next prev parent reply other threads:[~2011-04-03 0:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-03 0:18 vb2_plane 'mapped' signed bit field Dr. David Alan Gilbert
2011-04-03 0:24 ` Dr. David Alan Gilbert [this message]
2011-04-03 15:42 ` Pawel Osciak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110403002428.GD3062@gallifrey \
--to=linux@treblig.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=pawel@osciak.com \
--cc=zyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.