From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: Marek Vasut <marek.vasut@gmail.com>,
alsa-devel <alsa-devel@alsa-project.org>,
Eric Miao <eric.y.miao@gmail.com>,
Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [PATCH v2] ASoC: PXA: Fix oops in __pxa2xx_pcm_prepare
Date: Sun, 3 Apr 2011 18:55:16 +0900 [thread overview]
Message-ID: <20110403095503.GA17580@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1301730887-7755-1-git-send-email-anarsoul@gmail.com>
On Sat, Apr 02, 2011 at 10:54:47AM +0300, Vasily Khoruzhick wrote:
> pxa2xx_pcm_hw_free frees dma channel and sets prtd->dma_ch to -1,
> but does not set prtd->params to NULL, so if pxa2xx_pcm_hw_params will
> be called immediately, it leaves prtd->dma_ch initialized with -1,
> and it results in oops in __pxa2xx_pcm_prepare. This bug is triggered
> via SDL.
>
> This patch adds check for prtd->dma_ch to __pxa2xx_pcm_prepare and
> cleans prtd->params, so now it works properly.
Applied, thanks.
prev parent reply other threads:[~2011-04-03 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 19:35 [PATCH] ASoC: PXA: Fix oops in __pxa2xx_pcm_prepare Vasily Khoruzhick
2011-04-02 7:54 ` [PATCH v2] " Vasily Khoruzhick
2011-04-03 9:55 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110403095503.GA17580@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=anarsoul@gmail.com \
--cc=eric.y.miao@gmail.com \
--cc=lrg@slimlogic.co.uk \
--cc=marek.vasut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.