From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Christoph Hellwig <hch@infradead.org>,
Matthew Wilcox <willy@linux.intel.com>,
linux-scsi@vger.kernel.org, "Moore, Eric" <Eric.Moore@lsi.com>
Subject: Re: [PATCH 1/3] SCSI: Make cmd_serial_number an atomic
Date: Sun, 3 Apr 2011 09:33:06 -0400 [thread overview]
Message-ID: <20110403133306.GA22172@infradead.org> (raw)
In-Reply-To: <20110403131543.GF7286@parisc-linux.org>
On Sun, Apr 03, 2011 at 07:15:43AM -0600, Matthew Wilcox wrote:
> Hm, yeah, it looks like it's only used for checking whether the command
> we're aborting is the same command we're using to do the aborts. In
> which case, can't we simply do this? Eric?
A similar question also applies for the old fusion driver. There it
even compares the serial number with one taken from the same scsi_cmnd
in the same function. If we could reuse a scsi_cmnd while in the
->eh_abort handler for fusion it would have to seriously mess up it's
locking and lifetime rules.
next prev parent reply other threads:[~2011-04-03 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-01 20:20 [PATCH 1/3] SCSI: Make cmd_serial_number an atomic Matthew Wilcox
2011-04-02 13:36 ` Christoph Hellwig
2011-04-02 13:51 ` James Bottomley
2011-04-02 18:10 ` Jeff Garzik
2011-04-02 21:02 ` Matthew Wilcox
2011-04-03 11:00 ` Christoph Hellwig
2011-04-03 12:14 ` James Bottomley
2011-04-03 13:15 ` Matthew Wilcox
2011-04-03 13:33 ` Christoph Hellwig [this message]
2011-04-03 19:54 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110403133306.GA22172@infradead.org \
--to=hch@infradead.org \
--cc=Eric.Moore@lsi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.