From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54896 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Q6PkU-0003nC-KO
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 12:02:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q6PkP-0008Ou-DL
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 12:01:58 -0400
Received: from hall.aurel32.net ([88.191.126.93]:51853)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1Q6PkP-0008Om-8I
	for qemu-devel@nongnu.org; Sun, 03 Apr 2011 12:01:53 -0400
Date: Sun, 3 Apr 2011 18:01:49 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 01/10] target-arm: Make Neon helper
	routines use correct FP status
Message-ID: <20110403160149.GA8911@volta.aurel32.net>
References: <1301668243-29886-1-git-send-email-peter.maydell@linaro.org>
	<1301668243-29886-2-git-send-email-peter.maydell@linaro.org>
	<AANLkTinLgJDOaaMQft_gMpGjOgmZ33ojB+GV6kfPh9pY@mail.gmail.com>
	<AANLkTimMiHupSuDJdfOtpfrn9Ou_hRH=FtemGC+Y+DpK@mail.gmail.com>
	<BANLkTi=Arv9QE5t0jXW3WjCrjmvkjaG1mg@mail.gmail.com>
	<BANLkTin4o2NXVty8MsmYpmw3VVom4BrC+Q@mail.gmail.com>
	<BANLkTi=89=Lsq0NjuJkgqgHhD_eKuK123g@mail.gmail.com>
	<BANLkTimzh5VwSH_wemreFWL2o0A5QK+Zfg@mail.gmail.com>
	<20110403151214.GK31037@volta.aurel32.net>
	<BANLkTikMp+w_vHe1Q47tdtWcmwQ5vryMDg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <BANLkTikMp+w_vHe1Q47tdtWcmwQ5vryMDg@mail.gmail.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On Sun, Apr 03, 2011 at 04:32:51PM +0100, Peter Maydell wrote:
> On 3 April 2011 16:12, Aurelien Jarno <aurelien@aurel32.net> wrote:
> > On Sun, Apr 03, 2011 at 12:21:49PM +0100, Peter Maydell wrote:
> >> Anyway, how about I do a version of this patch which moves
> >> the affected neon helpers to op_helper.c rather than adding
> >> an env parameter
> 
> >> Then I can do a separate patchset to move other helpers,
> >> rather than tangling a code-cleanup patchset with Neon
> >> correctness fixes.
> 
> > This solution looks fine for me. That said, I am not sure moving
> > everything to op_helper.c is the best solution. I would rather go for
> > compiling *_helper.c with HELPER_CFLAGS, which avoids having one big
> > file which is messy to edit, and long to compile.
> 
> That sounds better, actually, and avoids moving too much
> code around. Still leaves the choice of:
>  * move VFP helpers from target-arm/helper.c to another file
>  * compile all target-*/helper.c with HELPER_CFLAGS

I am not sure you can do this one, as some functions there are not
called from the TCG code nor from code where env is in a fixed register.

>  * arm-specific exception in Makefile.target
> 
> of which I'll go for option 1.
> 
That's also my preferred option.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net