From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, sudarshan.bisht@nokia.com
Subject: Re: [PATCH 1/3 v3] alsa-lib: fixed coverity reported issues under "FORWARD_NULL" checker.
Date: Mon, 4 Apr 2011 12:49:15 +0100 [thread overview]
Message-ID: <20110404114915.GA26494@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <s5hpqp2ticg.wl%tiwai@suse.de>
On Mon, Apr 04, 2011 at 12:35:11PM +0200, Takashi Iwai wrote:
> Mark Brown wrote:
> > > - if (h == NULL)
> > > + if (h)
> > > snd_dlclose(h);
> > This is a coding style change, the two conditions are equivalent.
> I thought too at the first glance ;)
> It's the advantage of a systematic check.
Hrm, yes. Actually the issue here was that due to many of the other
changes I was reading very quickly - the patch looks a lot like a
misfiring automation.
next prev parent reply other threads:[~2011-04-04 11:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 8:53 [PATCH 1/3 v3] alsa-lib: fixed coverity reported issues under "FORWARD_NULL" checker sudarshan.bisht
2011-04-04 8:53 ` [PATCH 2/3 v3] alsa-lib: fixed coverity reported issues under "RESOURCE_LEAK" checker sudarshan.bisht
2011-04-04 17:30 ` Steve Calfee
2011-04-05 7:45 ` Sudarshan Bisht
2011-04-04 8:53 ` [PATCH 3/3 v3] alsa-lib: fixed coverity reported issues under "USE_AFTER_FREE" checker sudarshan.bisht
2011-04-04 9:12 ` Paul Menzel
2011-04-04 10:02 ` Sudarshan Bisht
2011-04-04 9:18 ` [PATCH 1/3 v3] alsa-lib: fixed coverity reported issues under "FORWARD_NULL" checker Mark Brown
2011-04-04 10:35 ` Takashi Iwai
2011-04-04 11:49 ` Mark Brown [this message]
2011-04-05 7:29 ` Sudarshan Bisht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110404114915.GA26494@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=sudarshan.bisht@nokia.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.