From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=52047 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q6qj4-0004os-GB for qemu-devel@nongnu.org; Mon, 04 Apr 2011 16:50:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q6qj3-00007y-3A for qemu-devel@nongnu.org; Mon, 04 Apr 2011 16:50:18 -0400 Received: from hall.aurel32.net ([88.191.126.93]:60165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q6qj2-00007u-Td for qemu-devel@nongnu.org; Mon, 04 Apr 2011 16:50:17 -0400 Date: Mon, 4 Apr 2011 22:50:13 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH] cpu-all.h: Remove unnecessary target-specific ifdef for CPU_QuadU Message-ID: <20110404205012.GD23034@volta.aurel32.net> References: <1301915362-2626-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1301915362-2626-1-git-send-email-peter.maydell@linaro.org> List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Alexander Graf On Mon, Apr 04, 2011 at 12:09:22PM +0100, Peter Maydell wrote: > CPU_QuadU isn't used on all targets, but there's no harm in defining the > typedef anyway. It only needs to be guarded by CONFIG_SOFTFLOAT, because > softfloat-native doesn't have a float128 type. This avoids the need for > every new target which uses CPU_QuadU to add itself to an #ifdef in > what ought to be target-agnostic code. > > Signed-off-by: Peter Maydell > --- > Noticed this one as a result of the s390 support patches; seems like > a minor but worthwhile cleanup to me... > > cpu-all.h | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) Thanks, applied. > diff --git a/cpu-all.h b/cpu-all.h > index 4cc445f..dc0f2f0 100644 > --- a/cpu-all.h > +++ b/cpu-all.h > @@ -138,11 +138,10 @@ typedef union { > uint64_t ll; > } CPU_DoubleU; > > -#if defined(TARGET_SPARC) || defined(TARGET_S390X) > +#if defined(CONFIG_SOFTFLOAT) > typedef union { > float128 q; > -#if defined(HOST_WORDS_BIGENDIAN) \ > - || (defined(__arm__) && !defined(__VFP_FP__) && !defined(CONFIG_SOFTFLOAT)) > +#if defined(HOST_WORDS_BIGENDIAN) > struct { > uint32_t upmost; > uint32_t upper; > -- > 1.7.1 > > > -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net