All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ted Ts'o <tytso@mit.edu>
To: Zhang Huan <zhhuan@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: potential memory leak on transaction commit
Date: Mon, 4 Apr 2011 18:10:09 -0400	[thread overview]
Message-ID: <20110404221009.GD2832@thunk.org> (raw)
In-Reply-To: <AANLkTi=ZPGd6scA8u3eSCzq1jgZWZdxs0p4p5knd2bN5@mail.gmail.com>

Hi Zhang,

Sorry for the delay in looking at it.  One thing which is missing from
your patch is a signed-off-by header.  From section 12 of the
Documentation/SubmittingPatches file in the Linux source tree:

>The sign-off is a simple line at the end of the explanation for the
>patch, which certifies that you wrote it or otherwise have the right to
>pass it on as a open-source patch.  The rules are pretty simple: if you
>can certify the below:
>
>        Developer's Certificate of Origin 1.1
>
>        By making a contribution to this project, I certify that:
>
>        (a) The contribution was created in whole or in part by me and I
>            have the right to submit it under the open source license
>            indicated in the file; or
>
>        (b) The contribution is based upon previous work that, to the best
>            of my knowledge, is covered under an appropriate open source
>            license and I have the right under that license to submit that
>            work with modifications, whether created in whole or in part
>            by me, under the same open source license (unless I am
>            permitted to submit under a different license), as indicated
>            in the file; or
>
>        (c) The contribution was provided directly to me by some other
>            person who certified (a), (b) or (c) and I have not modified
>            it.
>
>	(d) I understand and agree that this project and the contribution
>	    are public and that a record of the contribution (including all
>	    personal information I submit with it, including my sign-off) is
>	    maintained indefinitely and may be redistributed consistent with
>	    this project or the open source license(s) involved.
>
>then you just add a line saying
>
>	Signed-off-by: Random J Developer <random@developer.example.org>
>
>using your real name (sorry, no pseudonyms or anonymous contributions.)

If you could send me an acknowledgement that it would be OK to add a

Signed-off-by: Zhang Huan <zhhuan@gmail.com>

line to your patch, it would be much appreciated.

     	     	       	     	     - Ted

  reply	other threads:[~2011-04-04 22:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 11:40 potential memory leak on transaction commit Zhang Huan
2011-03-08 13:16 ` Lukas Czerner
2011-03-08 14:43   ` Zhang Huan
2011-03-08 16:13     ` Lukas Czerner
2011-03-15  6:39 ` Zhang Huan
2011-04-04 22:10   ` Ted Ts'o [this message]
2011-04-05 12:35     ` Zhang Huan
2011-04-05 23:27       ` Ted Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110404221009.GD2832@thunk.org \
    --to=tytso@mit.edu \
    --cc=linux-ext4@vger.kernel.org \
    --cc=zhhuan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.