Re: [SUBMIT REQUEST] cpupowerutils for linux-next

[Thomas Renninger <trenn@suse.de>]

On Monday 04 April 2011 16:40:11 Stephen Rothwell wrote:
> Hi Thomas,
> 
> On Mon, 4 Apr 2011 15:10:56 +0200 Thomas Renninger <trenn@suse.de>
> wrote:
> >
> > this is about the recently announced cpupowerutils project
> > based on or say an enhancement of the well know
> > cpufrequtils project:
> > http://www.spinics.net/lists/cpufreq/msg02137.html
> 
> Has integration of this into the kernel sources been discussed
> anywhere generally (like lkml)?
This is the first submit request.
> Has the work been done to integrate it into the
> kernel build system (I am not sure what this involves for the tools
> directory). 
No, it's separated like perf (but it is by far not that complex and
has not that much dependencies) or like tools/power/x86.

> At a first glance, it doesn't need it own copy of the
> COPYING file (for example).
While cpufrequtils has been developed by people working with
the kernel, there are probably more things like this to clean up
and get adopted.
It would be great to have it in linux-next for a while to get such
stuff addressed and cleaned up.
 
> I see that you asked Linus about this, but have receibed no reply (on
> list).
It was not very clever to simply add Linus into CC of this announcement,
asking for integration in the middle of a merge window...
 
> Code being merged into linux-next should be basically ready for
> merging into Linus' tree (apart from integration testing) and you need
> to be pretty sure that it will be merged by Linus into the next
> release (i.e. 2.6.40).  In this case that is not such a big issue as
> the code is (currently) all in a new directory, so will not interfere
> with other code.
Yes, it's totally separated and will not interfere.
80% of the code (cpufrequtils) is mature and well tested for years.
Recent changes are the cpuidle (cpupower idle-info) and monitor
parts. The integration to have one binary (command subcommand
style like perf/git/guilt/...), invoke manpages via --help, etc.
So yes, the code is ready for getting merged into Linus' tree, still
there hopefully will show up some bugfixes and enhancements
while it lives in linux-next.


    Thomas