From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Widawsky <ben@bwidawsk.net>
Subject: Re: [PATCH 5/5] drm/i915/gmbus: Reset the controller on
 initialisation
Date: Tue, 5 Apr 2011 09:27:35 -0700
Message-ID: <20110405162734.GC27748@snipes.kumite>
References: <1301995458-2699-1-git-send-email-chris@chris-wilson.co.uk>
	<1301995458-2699-6-git-send-email-chris@chris-wilson.co.uk>
	<20110405161837.GB27748@snipes.kumite>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org>
Received: from cloud01.chad-versace.us (184-106-247-128.static.cloud-ips.com
	[184.106.247.128])
	by gabe.freedesktop.org (Postfix) with ESMTP id EC7449E7B0
	for <intel-gfx@lists.freedesktop.org>;
	Tue,  5 Apr 2011 09:29:33 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <20110405161837.GB27748@snipes.kumite>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
	<mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

On Tue, Apr 05, 2011 at 09:18:37AM -0700, Ben Widawsky wrote:

> Outside of being able to do that directly, I would add a call to
> intel_i2c_reset() from intel_teardown_gmbus().

Hmm, forget that, I think this is silly. How about just a comment in the
code stating that intel_i2c_reset() should always be the first thing
that happens when you bring up the gmbus.

Ben