From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Arnaud Patard <arnaud.patard@rtp-net.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lrg@slimlogic.co.uk>
Subject: Re: [patch 1/1] sgtl5000: Fix suspend/resume
Date: Wed, 6 Apr 2011 08:23:53 +0900 [thread overview]
Message-ID: <20110405232352.GB6775@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <87aag5m8rn.fsf@lebrac.rtp-net.org>
On Tue, Apr 05, 2011 at 09:56:12AM +0200, Arnaud Patard wrote:
> Which means that reg cache size is SGTL5000_MAX_REG_OFFSET / 2 and
> register values stored without any "holes" in the array, except that in
> flat cache case, ASoC does :
> static int snd_soc_flat_cache_read(struct snd_soc_codec *codec,
> unsigned int reg, unsigned int
> *value)
> {
> *value = snd_soc_get_cache_val(codec->reg_cache, reg,
> codec->driver->reg_word_size);
> return 0;
> }
> and snd_soc_get_cache_val returns cache[reg] which means that the cache
> size must have a length of SGTL5000_MAX_REG_OFFSET and values stored
> with "holes".
But this means that _get_cache_val() needs to be fixed to take account
of the register cache step size. We shouldn't just pad the array, that
doesn't help.
prev parent reply other threads:[~2011-04-05 23:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 15:13 [patch 1/1] sgtl5000: Fix suspend/resume Arnaud Patard
2011-04-05 0:18 ` Mark Brown
2011-04-05 7:56 ` Arnaud Patard
2011-04-05 23:23 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405232352.GB6775@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.patard@rtp-net.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.