From: Anton Vorontsov <cbouatmailru@gmail.com>
To: Jamie Iles <jamie@jamieiles.com>
Cc: linux-kernel@vger.kernel.org, linux@arm.linux.org.uk,
tglx@linutronix.de, grant.likely@secretlab.ca, arnd@arndb.de,
nico@fluxnic.net
Subject: Re: [RFC PATCH 6/7] basic_mmio_gpio: support different input/output registers
Date: Wed, 6 Apr 2011 16:16:01 +0400 [thread overview]
Message-ID: <20110406121601.GA11329@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1302088263-12714-7-git-send-email-jamie@jamieiles.com>
On Wed, Apr 06, 2011 at 12:11:02PM +0100, Jamie Iles wrote:
> Some controllers have separate input and output registers. For these
> controllers, allow a register named "in" to be used for reading the
> value of a GPIO pin.
>
> Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> Cc: Anton Vorontsov <cbouatmailru@gmail.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>
> ---
[...]
> @@ -316,6 +340,8 @@ static int __devinit bgpio_probe(struct platform_device *pdev)
> if (!bgc->reg_dat)
> return -ENOMEM;
>
> + spin_lock_init(&bgc->lock);
> +
Hm. This looks like a stray change, now bgpio_probe() calls spin_lock_init()
twice.
Other than that, the patch seems to be OK.
Acked-by: Anton Vorontsov <cbouatmailru@gmail.com>
Thanks,
--
Anton Vorontsov
Email: cbouatmailru@gmail.com
next prev parent reply other threads:[~2011-04-06 12:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 11:10 [RFC PATCH 0/7] gpio: extend basic_mmio_gpio for different controllers Jamie Iles
2011-04-06 11:10 ` [RFC PATCH 1/7] basic_mmio_gpio: remove runtime width/endianness evaluation Jamie Iles
2011-04-06 12:12 ` Anton Vorontsov
2011-04-06 11:10 ` [RFC PATCH 2/7] basic_mmio_gpio: convert to platform_{get,set}_drvdata() Jamie Iles
2011-04-06 12:16 ` Anton Vorontsov
2011-04-06 11:10 ` [RFC PATCH 3/7] basic_mmio_gpio: allow overriding number of gpio Jamie Iles
2011-04-06 12:18 ` Anton Vorontsov
2011-04-06 11:11 ` [RFC PATCH 4/7] basic_mmio_gpio: request register regions Jamie Iles
2011-04-06 12:32 ` Anton Vorontsov
2011-04-06 11:11 ` [RFC PATCH 5/7] basic_mmio_gpio: detect output method at probe time Jamie Iles
2011-04-06 12:33 ` Anton Vorontsov
2011-04-06 11:11 ` [RFC PATCH 6/7] basic_mmio_gpio: support different input/output registers Jamie Iles
2011-04-06 12:16 ` Anton Vorontsov [this message]
2011-04-06 11:11 ` [RFC PATCH 7/7] basic_mmio_gpio: support direction registers Jamie Iles
2011-04-06 12:12 ` Anton Vorontsov
2011-04-08 0:14 ` Jamie Iles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406121601.GA11329@oksana.dev.rtsoft.ru \
--to=cbouatmailru@gmail.com \
--cc=arnd@arndb.de \
--cc=grant.likely@secretlab.ca \
--cc=jamie@jamieiles.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nico@fluxnic.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.