From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: linux-scsi@vger.kernel.org, DL-MPTFusionLinux@lsi.com
Subject: Re: [PATCH 1/2] mpt2sas: Remove acquisition of host_lock
Date: Wed, 6 Apr 2011 09:45:55 -0400 [thread overview]
Message-ID: <20110406134555.GA21729@infradead.org> (raw)
In-Reply-To: <20110405214355.GQ4183@linux.intel.com>
On Tue, Apr 05, 2011 at 05:43:55PM -0400, Matthew Wilcox wrote:
>
> We can eliminate the use of the scsi command serial_number, as the race
> that the driver is checking for cannot happen.
>
> Then the driver no longer needs to use the DEF_SCSI_QCMD() macro and no
> longer acquires the host_lock. This improves performance substantially
> on high-IOPS workloads.
Looks fine. Note that this somehow clashes with my patch to simply
remove the serial_number check from mpt2sas. We could just drop my
smaller patch if this one gets in in a timely fashion.
next prev parent reply other threads:[~2011-04-06 13:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 21:43 [PATCH 1/2] mpt2sas: Remove acquisition of host_lock Matthew Wilcox
2011-04-06 13:45 ` Christoph Hellwig [this message]
2011-04-07 5:30 ` Matthew Wilcox
2011-04-10 22:01 ` Moore, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406134555.GA21729@infradead.org \
--to=hch@infradead.org \
--cc=DL-MPTFusionLinux@lsi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.