From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [RFC][PATCH] powerpc/book3e: Fix CPU feature handling on e5500
Date: Wed, 6 Apr 2011 15:41:47 +1000 [thread overview]
Message-ID: <20110406154147.f736d92e.sfr@canb.auug.org.au> (raw)
In-Reply-To: <1302067772-32104-1-git-send-email-galak@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
Hi Kumar,
On Wed, 6 Apr 2011 00:29:32 -0500 Kumar Gala <galak@kernel.crashing.org> wrote:
>
> * I'm concerned if its ok to assume 'enum' can handle a 64-bit mask or not.
> I'm assuming this is the reason that we use a #define on __powerpc64__
enums are *ints* and therefore 32 bit. gcc can cope, but warns about it
(I think). So we must use the #define if any of the included bits are
above 2^32.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2011-04-06 5:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 5:29 [RFC][PATCH] powerpc/book3e: Fix CPU feature handling on e5500 Kumar Gala
2011-04-06 5:41 ` Stephen Rothwell [this message]
2011-04-06 12:26 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110406154147.f736d92e.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.