From: Christoph Egger <Christoph.Egger@amd.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] xen: fix hypervisor crash with xentrace
Date: Wed, 6 Apr 2011 15:32:00 +0100 [thread overview]
Message-ID: <201104061632.02099.Christoph.Egger@amd.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1944 bytes --]
Hi,
Attached patch fixes hypervisor crashes when xentrace buffer gets initialized.
The xen backtraces I have seen are:
(XEN) Xen call trace:
(XEN) [<ffff82c48025cf70>] early_stack+0x0/0x48
(XEN) [<ffff82c4801278d0>] tb_control+0x182/0x278
(XEN) [<ffff82c480124aac>] do_sysctl+0x1fc/0xa40
(XEN) [<ffff82c480213248>] syscall_enter+0xc8/0x122
(XEN)
(XEN) Pagetable walk from ffff82c48025cf70:
(XEN) L4[0x105] = 00000000cfcaa027 5555555555555555
(XEN) L3[0x112] = 00000000cfcab027 5555555555555555
(XEN) L2[0x001] = 000000022f27b063 5555555555555555
(XEN) L1[0x05c] = 00000000cfc5c262 5555555555555555
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 0:
(XEN) FATAL PAGE FAULT
(XEN) [error_code=0010]
(XEN) Faulting linear address: ffff82c48025cf70
(XEN) ****************************************
(XEN) Xen call trace:
(XEN) [<ffff82c48025d852>] notifier_chain_register+0x0/0x35
(XEN) [<ffff82c4801275b2>] alloc_trace_bufs+0x5cd/0x7a9
(XEN) [<ffff82c480127910>] tb_control+0x182/0x278
(XEN) [<ffff82c480124aec>] do_sysctl+0x1fc/0xa40
(XEN) [<ffff82c480213288>] syscall_enter+0xc8/0x122
(XEN)
(XEN) Pagetable walk from ffff82c48025d852:
(XEN) L4[0x105] = 00000000cfcaa027 5555555555555555
(XEN) L3[0x112] = 00000000cfcab027 5555555555555555
(XEN) L2[0x001] = 000000022f27b063 5555555555555555
(XEN) L1[0x05d] = 00000000cfc5d262 5555555555555555
(XEN)
(XEN) ****************************************
(XEN) Panic on CPU 1:
(XEN) FATAL PAGE FAULT
(XEN) [error_code=0010]
(XEN) Faulting linear address: ffff82c48025d852
(XEN) ****************************************
Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
--
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
[-- Attachment #2: xen_xentrace.diff --]
[-- Type: text/x-diff, Size: 927 bytes --]
diff -r 3fd604b77a5e xen/common/cpu.c
--- a/xen/common/cpu.c Wed Apr 06 16:03:15 2011 +0200
+++ b/xen/common/cpu.c Wed Apr 06 16:27:42 2011 +0200
@@ -54,7 +54,7 @@ void cpu_hotplug_done(void)
static NOTIFIER_HEAD(cpu_chain);
-void __init register_cpu_notifier(struct notifier_block *nb)
+void register_cpu_notifier(struct notifier_block *nb)
{
if ( !spin_trylock(&cpu_add_remove_lock) )
BUG(); /* Should never fail as we are called only during boot. */
diff -r 3fd604b77a5e xen/common/notifier.c
--- a/xen/common/notifier.c Wed Apr 06 16:03:15 2011 +0200
+++ b/xen/common/notifier.c Wed Apr 06 16:27:42 2011 +0200
@@ -19,7 +19,7 @@
* Adds a notifier to a raw notifier chain.
* All locking must be provided by the caller.
*/
-void __init notifier_chain_register(
+void notifier_chain_register(
struct notifier_head *nh, struct notifier_block *n)
{
struct list_head *chain = &nh->head.chain;
[-- Attachment #3: Type: text/plain, Size: 138 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel
next reply other threads:[~2011-04-06 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 14:32 Christoph Egger [this message]
2011-04-06 14:36 ` [PATCH] xen: fix hypervisor crash with xentrace Christoph Egger
2011-04-06 15:01 ` Jan Beulich
2011-04-06 14:54 ` Keir Fraser
2011-04-06 15:03 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201104061632.02099.Christoph.Egger@amd.com \
--to=christoph.egger@amd.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.