Re: [lm-sensors] [PATCH v4] hwmon: Add support for MAX6642

[Guenter Roeck <guenter.roeck@ericsson.com>]

On Wed, Apr 06, 2011 at 03:06:13PM -0400, Per Dalén wrote:
> On 04/06/2011 08:58 PM, Guenter Roeck wrote:
> > Hi Per,
> > 
> > On Wed, Apr 06, 2011 at 02:29:44PM -0400, Per Dalén wrote:
> >> First a big thanks to Guenter Roeck for helping me (allot) to cleanup
> >> this driver
> >>
> >> v3 -> v4:
> >>  * Removed "data->valid = 0;" (missed that in v3 ;)
> >>  * only read the limits once
> >>  * changed the temp_input and temp_high as suggested by Guenter, also
> >> changed the functions/macros related to that change
> > 
> >> MAX6642 is a SMBus-Compatible Remote/Local Temperature Sensor with Overtemperature Alarm from Maxim.
> >>  
> >> Signed-off-by: Per Dalen <per.dalen@appeartv.com>
> >>
> > Sorry, one more detail I just noticed. More of a question.
> > 
> > [ ... ]
> >> +
> >> +static struct max6642_data *max6642_update_device(struct device *dev)
> >> +{
> >> +	struct i2c_client *client = to_i2c_client(dev);
> >> +	struct max6642_data *data = i2c_get_clientdata(client);
> >> +	u16 val, tmp;
> >> +
> >> +	mutex_lock(&data->update_lock);
> >> +
> >> +	if (time_after(jiffies, data->last_updated + HZ * 8) || !data->valid) {
> > 
> > Are you sure you only want to update readings every 8 seconds ?
> 
> No, this is wrong from me. Every second, or what do you think?
> 
No need to re-submit. I applied v4 of your patch, changing the above to HZ.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors