All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hirofumi@mail.parknet.co.jp
Cc: netdev@vger.kernel.org
Subject: Re: problem of "ipv4: revert Set rt->rt_iif more sanely on output routes."
Date: Thu, 07 Apr 2011 14:03:33 -0700 (PDT)	[thread overview]
Message-ID: <20110407.140333.189683738.davem@davemloft.net> (raw)
In-Reply-To: <8739lusbvz.fsf@devron.myhome.or.jp>

From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Date: Thu, 07 Apr 2011 17:29:04 +0900

> I'm not sure
> 
> +	rth->rt_route_iif = 0;
> +	rth->rt_iif	= oldflp4->flowi4_oif ? : dev_out->ifindex;
> 
> is correct one or not. Please review.

I am pretty sure this is indeed correct.

In old code this read:

	rth->rt_iif	= oldflp->oif ? : dev_out->ifindex;

And rt->fl.iif was left without explicit setting, and thus left
as zero (dst_alloc() use to bzero entire rtable object).

So new code is equivalent and provides the necessary semantics.

I think your patch is correct and I will add it to net-2.6, thanks
again!


      parent reply	other threads:[~2011-04-07 21:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-05 13:05 problem of "ipv4: revert Set rt->rt_iif more sanely on output routes." OGAWA Hirofumi
2011-04-05 14:11 ` OGAWA Hirofumi
2011-04-05 14:57   ` OGAWA Hirofumi
2011-04-06 20:28 ` David Miller
2011-04-07  4:31   ` OGAWA Hirofumi
2011-04-07  5:34     ` David Miller
2011-04-07  5:42       ` David Miller
2011-04-07  7:19         ` OGAWA Hirofumi
2011-04-07  8:29           ` OGAWA Hirofumi
2011-04-07  8:32             ` OGAWA Hirofumi
2011-04-07 20:58               ` David Miller
2011-04-07 21:03             ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110407.140333.189683738.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hirofumi@mail.parknet.co.jp \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.