From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/9] xfs: fix extent format buffer allocation size
Date: Thu, 7 Apr 2011 10:05:05 +1000 [thread overview]
Message-ID: <20110407000505.GM31057@dastard> (raw)
In-Reply-To: <20110406133816.GA16276@infradead.org>
On Wed, Apr 06, 2011 at 09:38:17AM -0400, Christoph Hellwig wrote:
> On Wed, Apr 06, 2011 at 04:19:10PM +1000, Dave Chinner wrote:
> > + ext_buffer = kmem_alloc(XFS_IFORK_SIZE(ip, whichfork),
> > + KM_SLEEP | KM_NOFS);
>
> As mentioned before the KM_NOFS is a change from the previous version
> and really should not be needed.
Ok. If you feel strongly enough to point it out a second time, I'll
fix it ;)
> Also the feedback that the new helper needs to be under the
> !XFS_NATIVE_ENDIAN ifdef wasn't picked up either.
The function is needed regardless of XFS_NATIVE_HOST due to the fact
it is needed to pick the real extents out of the n-core data fork
when delayed allocation extents are present. This is endian
independent.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2011-04-07 0:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 6:19 [PATCH 0/9] xfs: candidate fixes for 2.6.39 Dave Chinner
2011-04-06 6:19 ` [PATCH 1/9] xfs: fix extent format buffer allocation size Dave Chinner
2011-04-06 13:38 ` Christoph Hellwig
2011-04-07 0:05 ` Dave Chinner [this message]
2011-04-07 17:19 ` Christoph Hellwig
2011-04-06 6:19 ` [PATCH 2/9] xfs: introduce a xfssyncd workqueue Dave Chinner
2011-04-06 6:19 ` [PATCH 3/9] xfs: convert ENOSPC inode flushing to use new syncd workqueue Dave Chinner
2011-04-06 6:19 ` [PATCH 4/9] xfs: introduce background inode reclaim work Dave Chinner
2011-04-06 18:14 ` Christoph Hellwig
2011-04-07 0:06 ` Dave Chinner
2011-04-06 6:19 ` [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue Dave Chinner
2011-04-06 18:12 ` Christoph Hellwig
2011-04-07 0:08 ` Dave Chinner
2011-04-06 6:19 ` [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c Dave Chinner
2011-04-06 18:17 ` Christoph Hellwig
2011-04-07 0:08 ` Dave Chinner
2011-04-06 6:19 ` [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync Dave Chinner
2011-04-06 18:33 ` Christoph Hellwig
2011-04-07 0:15 ` Dave Chinner
2011-04-06 6:19 ` [PATCH 8/9] xfs: catch bad block numbers freeing extents Dave Chinner
2011-04-06 13:59 ` Christoph Hellwig
2011-04-07 0:18 ` Dave Chinner
2011-04-06 6:19 ` [PATCH 9/9] xfs: convert log tail checking to a warning Dave Chinner
2011-04-06 14:02 ` Christoph Hellwig
2011-04-07 0:25 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2011-04-07 1:57 [PATCH 0/9] xfs; candidate fixes for 2.6.39 V2 Dave Chinner
2011-04-07 1:57 ` [PATCH 1/9] xfs: fix extent format buffer allocation size Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110407000505.GM31057@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.