All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <guenter.roeck@ericsson.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v3] hwmon: Add submitting-patches checklist
Date: Thu, 07 Apr 2011 14:05:06 +0000	[thread overview]
Message-ID: <20110407140506.GA31160@ericsson.com> (raw)
In-Reply-To: <1302110273-23692-1-git-send-email-guenter.roeck@ericsson.com>

On Thu, Apr 07, 2011 at 04:12:23AM -0400, Jean Delvare wrote:
> On Wed, 6 Apr 2011 10:17:53 -0700, Guenter Roeck wrote:
> > When writing hardware monitoring drivers, there are some common pitfalls which
> > keep coming up in code reviews. This patch provides a document describing all
> > those pitfalls and how to avoid them.
> > 
> > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> 
> Acked-by: Jean Delvare <khali@linux-fr.org>
> 
> Minor suggestion below - but no need to resend.
> 
> > +* Provide a detect function only if a chip can be detected reliably. On the
> > +  other side, if the chip can be detected reliably, provide a detect function.
> 
> Could be expressed in a more compact way as:
> 
> * Provide a detect function if and only if a chip can be detected reliably.
> 
Mathematically correct, but would people understand it ?

> (But maybe this is the mathematician in me speaking!)
> 
Mathematician myself, I prefer your wording as well. I'll go with it.

Thanks,
Guenter

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  parent reply	other threads:[~2011-04-07 14:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-06 17:17 [lm-sensors] [PATCH v3] hwmon: Add submitting-patches checklist to Guenter Roeck
2011-04-07  8:12 ` [lm-sensors] [PATCH v3] hwmon: Add submitting-patches checklist Jean Delvare
2011-04-07 14:05 ` Guenter Roeck [this message]
2011-04-07 16:04 ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110407140506.GA31160@ericsson.com \
    --to=guenter.roeck@ericsson.com \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.