All of lore.kernel.org
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] pxa270 rtc wakeup event fix
Date: Fri, 8 Apr 2011 21:36:52 +0200	[thread overview]
Message-ID: <201104082136.52297.marek.vasut@gmail.com> (raw)
In-Reply-To: <4D9F3AE4.2040101@gmail.com>

On Friday 08 April 2011 18:42:12 Nick Bane wrote:
> This fixes the failure to register the IRQ_RTCAlrm alarm as a wakeup event.
> It is misinterpreted as a gpio irq not a PWER bitmask.
> 
> Nick Bane

CCing Haojian and Eric.

> 
> Index: linux-2.6.38/arch/arm/mach-pxa/pxa27x.c
> ===================================================================

Please use git format-patch

Thanks, cheers

> --- linux-2.6.38.orig/arch/arm/mach-pxa/pxa27x.c    2011-04-07
> 21:07:54.000000000 +0100
> +++ linux-2.6.38/arch/arm/mach-pxa/pxa27x.c    2011-04-07
> 21:08:40.000000000 +0100
> @@ -341,6 +341,11 @@
>   static inline void pxa27x_init_pm(void) {}
>   #endif
> 
> +static int is_gpio_irq(int irq)
> +{
> +    return (irq == IRQ_GPIO0) || (irq == IRQ_GPIO1) || (irq >=
> PXA_GPIO_IRQ_BASE);
> +}
> +
>   /* PXA27x:  Various gpios can issue wakeup events.  This logic only
>    * handles the simple cases, not the WEMUX2 and WEMUX3 options
>    */
> @@ -349,7 +354,7 @@
>       int gpio = IRQ_TO_GPIO(d->irq);
>       uint32_t mask;
> 
> -    if (gpio >= 0 && gpio < 128)
> +    if (is_gpio_irq(d->irq) && gpio >= 0 && gpio < 128)
>           return gpio_set_wake(gpio, on);
> 
>       if (d->irq == IRQ_KEYPAD)
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2011-04-08 19:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-08 16:42 [PATCH] pxa270 rtc wakeup event fix Nick Bane
2011-04-08 19:36 ` Marek Vasut [this message]
2011-04-12  7:44   ` Eric Miao
2011-04-12  8:28     ` Nick Bane
2011-04-12  9:56       ` Igor Grinberg
2011-04-12 10:53     ` Marek Vasut
2011-04-12 13:47       ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201104082136.52297.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.